#1017 make marshaller composition more lazy #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akka-ci
added
validating
|
Test PASSed. |
jrudolph
reviewed
Apr 13, 2017
| val f2 = (_: ExecutionContext) ⇒ (a: A) ⇒ FastFuture.successful(f1(a) :: Nil) | ||
| new Marshaller[A, B] { | ||
| def apply(value: A)(implicit ec: ExecutionContext) = | ||
| try f2(ec)(value) |
There was a problem hiding this comment.
Could you inline those functions? The whole execution is strict so preallocation those lambdas is not beneficial.
Good analysis, thanks. |
|
@raboof can you inline those lambdas and merge after validation? Would be nice to have in the next release? |
|
I'll merge and cleanup |
ktoso
changed the title
|
Resolves #1017 |
raboof
added a commit
that referenced
this pull request
Apr 28, 2017
I have this nagging feeling this could be made more elegant by doing something other than making these anonymous `Marshaller` subclasses and overriding 'compose', but for now this'll do :).
ktoso
pushed a commit
that referenced
this pull request
Apr 28, 2017
I have this nagging feeling this could be made more elegant by doing something other than making these anonymous `Marshaller` subclasses and overriding 'compose', but for now this'll do :).
tomrf1
pushed a commit
to tomrf1/akka-http
that referenced
this pull request
Aug 13, 2017
I have this nagging feeling this could be made more elegant by doing something other than making these anonymous `Marshaller` subclasses and overriding 'compose', but for now this'll do :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
Marshalling.oneOf, in some situations each marshaller is actually executed before picking the most suitable result.While indeed we can't avoid allocating a
Marshallingfor eachMarshaller(that would need a wider overhaul as described in #243), the actual marshalling can still be lazy at that point (https://github.com/akka/akka-http/blob/master/akka-http/src/main/scala/akka/http/scaladsl/marshalling/Marshaller.scala#L168).It seems
Marshaller.composeis forcing the early evaluation. This PR appears to confirm that, though it isn't obvious we can work that through without performing the ugly hacks in here.