Docs cleanups, clarifications, and fixes #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It was copy pastered from the original one page doc so probably a lot can be cut out |
raboof
reviewed
Oct 16, 2018
helena
previously requested changes
Nov 14, 2018
Co-Authored-By: jrudolph <johannes.rudolph@gmail.com>
jrudolph
commented
Nov 15, 2018
jrudolph
commented
Nov 15, 2018
jrudolph
commented
Nov 15, 2018
Co-Authored-By: jrudolph <johannes.rudolph@gmail.com>
Yep, indeed. I'll apply the remaining suggestions.
👍 Thanks a lot. |
|
Thanks for the reviews and sorry for keeping that hanging after my vacation. I fixed a few more small things. |
|
Created #388 to deduplicate the bootstrap details page as I don't get to that immediately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still working on the bootstrap details page which I find a bit confusing because it is quite redundant.