Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify when to shut down Akka management #291

Open
sebarys opened this issue Sep 7, 2018 · 3 comments
Open

Clarify when to shut down Akka management #291

sebarys opened this issue Sep 7, 2018 · 3 comments

Comments

@sebarys
Copy link

sebarys commented Sep 7, 2018

Hi,

I have a question: do I need to manually stop akka-management in my custom Task when using akka coordinated shutdown extension ( https://doc.akka.io/docs/akka/2.5.6/scala/actors.html#coordinated-shutdown )?

Additionally I found in akka-management documentation sentence: "In a dynamic environment you might stop instances of Akka Management, for example if you don’t want to free up resources taken by the HTTP server serving the Management routes." ( https://developer.lightbend.com/docs/akka-management/current/akka-management.html#stopping-akka-management )
Should not it be rather "if you want to free up" instead of "if you don’t want to free up" ?

Thanks,
sebarys

@patriknw
Copy link
Member

I don't think there is a need for explicit stopping from coordinated shutdown. The ActorSystem is anyway about to be stopped and Akka Management will be stopped with that at the end.

The negation must be wrong.

I also think that advice can be misleading if used together with Bootstrap.

@chbatey chbatey changed the title akka-management and CoordinatedShutdown Clarify when to shut down Akka management Sep 18, 2018
@chbatey
Copy link
Member

chbatey commented Sep 18, 2018

Yep new nodes will need the http endpoints for bootstrap so we can fix the docs under this issue

@glammers1
Copy link
Contributor

glammers1 commented Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants