Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider returning Mat value on Projection.stop #44

Closed
octonato opened this issue Apr 9, 2020 · 0 comments
Closed

Consider returning Mat value on Projection.stop #44

octonato opened this issue Apr 9, 2020 · 0 comments
Assignees
@octonato
Milestone
0.1.0

Comments

@octonato
Copy link
Member

octonato commented Apr 9, 2020

Maybe the returned Future should be the mat val Future of Sink.ignore?
Then we should maybe also expose that as a getter. Not sure what to name it. def whenStopped: Future[Done].
Purpose of that is to be able to observe that the projection failed/completed for other reasons than stop().

Originally posted by @patriknw in #35
This was referenced Apr 9, 2020
Merged
Closed
@patriknw patriknw added this to the 0.1.0 milestone Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@octonato octonato

Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
2 participants
@patriknw @octonato