Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues in streams pointed out by Jason #15026

Closed
rkuhn opened this issue Apr 17, 2014 · 2 comments
Closed

fix issues in streams pointed out by Jason #15026

rkuhn opened this issue Apr 17, 2014 · 2 comments
Assignees
Milestone

Comments

@rkuhn
Copy link
Contributor

rkuhn commented Apr 17, 2014

See @retronym’s comments on 248c0a3.

@rkuhn rkuhn added this to the streams-0.3 milestone Apr 17, 2014
@patriknw
Copy link
Member

In summary:

  • change that Flow.apply thunk to accept a closure that returns Some/None instead
  • document and test the behaviour for negative n in take and drop
  • documenting the behaviour with exceptions from operators
  • Use of uncheckedVariance ought to be justified with a comment. ("It is safe because ... / We can't use bounded method type params instead because ...")
  • Scaladoc should either link or backtick things like FlowMaterializer
  • documentation or more thought around thread local based withCtx, it relies on that the sub-flow is always created on the calling thread

@ktoso
Copy link
Member

ktoso commented Aug 21, 2014

Notes to the todo list in patrik's comment:

@patriknw patriknw modified the milestones: streams-0.6, streams-0.7 Aug 22, 2014
@rkuhn rkuhn added the medium label Aug 25, 2014
@patriknw patriknw self-assigned this Aug 26, 2014
patriknw added a commit that referenced this issue Aug 26, 2014
patriknw added a commit that referenced this issue Aug 26, 2014
patriknw added a commit that referenced this issue Aug 29, 2014
patriknw added a commit that referenced this issue Aug 29, 2014
patriknw added a commit that referenced this issue Aug 29, 2014
ktoso pushed a commit to ktoso/akka that referenced this issue Jan 11, 2016
ktoso pushed a commit to ktoso/akka that referenced this issue Jan 11, 2016
ktoso pushed a commit to ktoso/akka that referenced this issue Jan 11, 2016
ktoso pushed a commit to ktoso/akka that referenced this issue Jan 11, 2016
ktoso pushed a commit to ktoso/akka that referenced this issue Jan 11, 2016
ktoso pushed a commit to ktoso/akka that referenced this issue Jan 11, 2016
ktoso pushed a commit to ktoso/akka that referenced this issue Jan 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants