Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Typesafe config to 1.3.0-M3 #17071

Closed
rkuhn opened this issue Mar 25, 2015 · 8 comments · Fixed by #17408
Closed

update Typesafe config to 1.3.0-M3 #17071

rkuhn opened this issue Mar 25, 2015 · 8 comments · Fixed by #17408
Milestone

Comments

@rkuhn
Copy link
Contributor

rkuhn commented Mar 25, 2015

from Havoc:

Here's what's new:
https://github.com/typesafehub/config/blob/master/NEWS.md#130-m1-march-6-2015

It probably makes sense to move current dev versions of akka and play
to this release and see if anything explodes. I would do a 1.3.0 final
before your projects go final, of course.

At this time all the open issues are feature requests or I couldn't
reproduce them. I don't know of anything that's broken. So if you find
anything let me know.

I think akka was implementing the Config interface, which has new
methods added, so it probably will not compile. Config is "sealed by
documentation" by the way since Java doesn't have sealed. :-)

However, the optimizations to path parsing in this release may mean
the caching you were doing isn't needed anymore. Details of those
optimizations are at lightbend/config#205
in case you feel like deleting code. I think even more optimization
could be possible but it's already fast so you will have to tell me if
it matters to you.

@rkuhn rkuhn added this to the 2.4-M1 milestone Mar 25, 2015
@rkuhn rkuhn added the 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted label Mar 25, 2015
@He-Pin
Copy link
Member

He-Pin commented Mar 25, 2015

+1 for that.and maybe the cachedConfig is no longer needed

@He-Pin
Copy link
Member

He-Pin commented Apr 2, 2015

then it should be1.3.0-M2 :P

@rkuhn
Copy link
Contributor Author

rkuhn commented May 4, 2015

@patriknw This should be done soon as well.

@ktoso ktoso changed the title update Typesafe config to 1.3.0-M1 update Typesafe config to 1.3.0-M3 May 7, 2015
@ktoso ktoso added 3 - in progress Someone is working on this ticket and removed 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted labels May 7, 2015
@ktoso
Copy link
Member

ktoso commented May 7, 2015

Requires minor changes in code on our side, I'll solve it

@patriknw
Copy link
Member

patriknw commented May 7, 2015

Great, later we might want to try to remove the caching workaround. Havoc said that the new version might be fast enough. Please create a new ticket for that task.

@ktoso
Copy link
Member

ktoso commented May 7, 2015

I checked if we need CachingConfig still, and yeah I think we do:

@Benchmark def deep_config  = deepConfig.hasPath(deepKey)
@Benchmark def deep_caching = deepCaching.hasPath(deepKey)

[info] Benchmark                                            Mode  Samples       Score  Score error   Units
[info] a.d.CachingConfigBenchmarkBenchmark.deep_caching    thrpt       40  146234.778     3638.332  ops/ms
[info] a.d.CachingConfigBenchmarkBenchmark.deep_config     thrpt       40    3165.616      140.646  ops/ms

@ktoso
Copy link
Member

ktoso commented May 7, 2015

Should I create the ticket anyway, to revisit at some point in the future?

@patriknw
Copy link
Member

patriknw commented May 7, 2015

awesome, if you have already checked we don't need a ticket

ktoso added a commit to ktoso/akka that referenced this issue May 10, 2015
ktoso added a commit to ktoso/akka that referenced this issue May 19, 2015
ktoso added a commit to ktoso/akka that referenced this issue May 19, 2015
patriknw added a commit that referenced this issue May 19, 2015
@patriknw patriknw removed the 3 - in progress Someone is working on this ticket label May 19, 2015
ktoso pushed a commit to ktoso/akka that referenced this issue Jan 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants