Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to pass one UT in akka\akka-actor-tests\src\test\java\akka\util\ByteStringTest.java #20090

Closed
wjingyao2008 opened this issue Mar 20, 2016 · 1 comment · Fixed by #20113
Assignees
Labels
Milestone

Comments

@wjingyao2008
Copy link

hi, i am newbie to akka source code,

i recently download the code from master branch,but failed one unite test in
\akka\akka-actor-tests\src\test\java\akka\util\ByteStringTest.java,

i think the "World" should be " World",with space appended ahead.

i am not very sure because this bug seems too easy , am i wrong??

@Test
  public void testBuilderCreation() {
    final ByteStringBuilder sb = ByteString.createBuilder();
    sb.append(ByteString.fromString("Hello"));
    sb.append(ByteString.fromString("World"));
    assertEquals(ByteString.fromString("Hello World"), sb.result());
  }

junit.framework.AssertionFailedError:
Expected :ByteString(72, 101, 108, 108, 111, 32, 87, 111, 114, 108, 100)
Actual :ByteString(72, 101, 108, 108, 111, 87, 111, 114, 108, 100)

at junit.framework.Assert.fail(Assert.java:57)
at junit.framework.Assert.failNotEquals(Assert.java:329)
at junit.framework.Assert.assertEquals(Assert.java:78)
at junit.framework.Assert.assertEquals(Assert.java:86)
at junit.framework.TestCase.assertEquals(TestCase.java:253)
at akka.util.ByteStringTest.testBuilderCreation(ByteStringTest.java:24)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:119)
at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:42)
at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:234)
at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:74)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)

@ktoso
Copy link
Member

ktoso commented Mar 20, 2016

Oh wow, seems so... But that means the juare not run by jenkins then?
We should figure out why that's happening in the first place - would you be able to have a look as well?

@ktoso ktoso added bug 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding 3 - in progress Someone is working on this ticket and removed 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding labels Mar 20, 2016
@ktoso ktoso added this to the 2.4.x milestone Mar 22, 2016
@ktoso ktoso self-assigned this Mar 22, 2016
@ktoso ktoso modified the milestones: 2.4.3, 2.4.x Mar 22, 2016
ktoso added a commit to ktoso/akka that referenced this issue Mar 22, 2016
ktoso added a commit to ktoso/akka that referenced this issue Mar 29, 2016
@ktoso ktoso modified the milestones: 2.4.4, 2.4.3 Apr 1, 2016
ktoso added a commit to ktoso/akka that referenced this issue Apr 5, 2016
ktoso added a commit to ktoso/akka that referenced this issue Apr 5, 2016
@ktoso ktoso removed the 3 - in progress Someone is working on this ticket label Apr 5, 2016
@ktoso ktoso modified the milestones: 2.4.4, 2.4.5 Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants