Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"lost" timer message in PersistentActor #24076

Closed
patriknw opened this issue Nov 30, 2017 · 0 comments
Closed

"lost" timer message in PersistentActor #24076

patriknw opened this issue Nov 30, 2017 · 0 comments
Assignees
@patriknw
Labels
bug t:persistence
Milestone
2.5.8

Comments

@patriknw
Copy link
Member

patriknw commented Nov 30, 2017 •
edited
Loading

It will be seen in debug logs as

"Received timer [{}] that has been removed, discarding"

The reason is that if the PersistentActor is waiting for persist confirmation it will stash the incoming message, and the TimerSchedulerImpl.interceptTimerMsg (called from aroundReceive before the PersistentActor.aroundReceive) has then already processed the msg. When it is unstashed it's discarded.

I think we can't support mixing in that order PersistentActor with Timers. It must be Timers with PersistentActor.T hat is also somewhat difficult because PersistentActor aroundReceive is terminal, but I think we can make it aware of Timers.
@patriknw patriknw self-assigned this Dec 1, 2017
@patriknw patriknw added the 3 - in progress Someone is working on this ticket label Dec 1, 2017
patriknw added a commit that referenced this issue Dec 1, 2017
@patriknw
enforce right order of Timers and PersistentActor trait, #24076
844875c 
* the order was also wrong in the AbstractPersistentActorWithTimers
* mima complains about this change for AbstractPersistentActor and
  AbstractPersistentActorWithAtLeastOnceDelivery, but I think it is ok
@patriknw patriknw mentioned this issue Dec 1, 2017
Merged
ktoso pushed a commit that referenced this issue Dec 5, 2017
@patriknw @ktoso
enforce right order of Timers and PersistentActor trait, #24076 (#24081)
11d628d 
* the order was also wrong in the AbstractPersistentActorWithTimers
* mima complains about this change for AbstractPersistentActor and
  AbstractPersistentActorWithAtLeastOnceDelivery, but I think it is ok
@ktoso ktoso removed the 3 - in progress Someone is working on this ticket label Dec 5, 2017
@ktoso ktoso closed this as completed Dec 5, 2017
@ktoso ktoso added this to the 2.5.8 milestone Dec 5, 2017
manonthegithub pushed a commit to manonthegithub/akka that referenced this issue Jan 31, 2018
@patriknw @manonthegithub
enforce right order of Timers and PersistentActor trait, akka#24076 (a…
73b4fb2 
…kka#24081)

* the order was also wrong in the AbstractPersistentActorWithTimers
* mima complains about this change for AbstractPersistentActor and
  AbstractPersistentActorWithAtLeastOnceDelivery, but I think it is ok
@412b 412b mentioned this issue Feb 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patriknw patriknw

Labels
bug t:persistence
Projects
None yet
Milestone
2.5.8
Development

No branches or pull requests
2 participants
@ktoso @patriknw