Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for custom ActorSystem when creating typed ActorTestkit #27338

Closed
Reklund3 opened this issue Jul 12, 2019 · 2 comments
Closed

Allow for custom ActorSystem when creating typed ActorTestkit #27338

Reklund3 opened this issue Jul 12, 2019 · 2 comments
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted help wanted Issues that the core team will likely not have time to work on t:testing t:typed
Milestone
2.6.5

Comments

@Reklund3
Copy link
Contributor

Feature Request,

Use Case: Enhance the ActorTestKit (typed) to allow for creating and/or passing an Actor
System. Additionally, this would allow for testing Typed Actor Systems and their corresponding
interaction with Lagom Persistent Entites.

This request is for the following:

  • A method that takes an ActorSystemSetup
  • A method that takes an ActorSystem

Reference Discussion: https://discuss.lightbend.com/t/typed-actor-testkit/4569/2

Regards,
Robert
@johanandren johanandren added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:testing t:typed help wanted Issues that the core team will likely not have time to work on labels Jul 12, 2019
@johanandren johanandren changed the title Akka-TestKit-Typed & Persistent Entities Testing Integration Allow for custom ActorSystem when creating typed ActorTestkit Jul 12, 2019
@johanandren
Copy link
Member

I think we only need a factory to create it with a custom ActorSystem as that would also cover creating the actor system with custom ActorSystemSetup

@Reklund3
Copy link
Contributor Author

I concur, I think this approach will accomplish our goal.

Reklund3 pushed a commit to Reklund3/akka that referenced this issue Apr 2, 2020
Add apply methods for typed ActorTestKit allowing for passing an Acto…
889c923 
…rSystem or ActorSystemSetup (akka#27338).

Added an apply method that takes a akka.actor.typed.ActorSystem and generates a ActorTestKit.
Added an apply method that takes a string and akka.actor.setup.ActorSystemSetup and generates an ActorTestKit

Modified the internal ActorTestKit class to use an ActorSystemSetup instead of a config and updated the other apply methods to generate an ActorSystemSetup in place of the config.
This was an attempt to maintain compatability.

added the related test specs for the new apply methods and updated the apply methods that changed.
@Reklund3 Reklund3 mentioned this issue Apr 2, 2020
Open
@patriknw patriknw mentioned this issue Apr 2, 2020
Closed
Reklund3 pushed a commit to Reklund3/akka that referenced this issue Apr 2, 2020
Add apply methods for typed ActorTestKit Javadsl (akka#27338)
3745539
Reklund3 pushed a commit to Reklund3/akka that referenced this issue Apr 2, 2020
Correcting apply method doc comments for Javadsl apply methods (akka#…
73e55d9 
…27338)
@Reklund3 Reklund3 mentioned this issue Apr 2, 2020
Merged
Reklund3 pushed a commit to Reklund3/akka that referenced this issue Apr 3, 2020
Add apply methods for typed ActorTestKit allowing for passing an Acto…
60b2d0c 
…rSystem or ActorSystemSetup (akka#27338).

Added an apply method that takes a akka.actor.typed.ActorSystem and generates a ActorTestKit.
Added an apply method that takes a string and akka.actor.setup.ActorSystemSetup and generates an ActorTestKit

Modified the internal ActorTestKit class to use an ActorSystemSetup instead of a config and updated the other apply methods to generate an ActorSystemSetup in place of the config.
This was an attempt to maintain compatability.

added the related test specs for the new apply methods and updated the apply methods that changed.
Reklund3 pushed a commit to Reklund3/akka that referenced this issue Apr 3, 2020
Add apply methods for typed ActorTestKit Javadsl (akka#27338) fix author
b56d305
Reklund3 pushed a commit to Reklund3/akka that referenced this issue Apr 3, 2020
Correcting apply method doc comments for Javadsl apply methods (akka#…
08d3ce7 
…27338) fix author
Reklund3 added a commit to Reklund3/akka that referenced this issue Apr 3, 2020
@Reklund3
Add apply methods for typed ActorTestKit allowing for passing an Acto…
bcd29c1 
…rSystem or ActorSystemSetup (akka#27338).

Added an apply method that takes a akka.actor.typed.ActorSystem and generates a ActorTestKit.
Added an apply method that takes a string and akka.actor.setup.ActorSystemSetup and generates an ActorTestKit

Modified the internal ActorTestKit class to use an ActorSystemSetup instead of a config and updated the other apply methods to generate an ActorSystemSetup in place of the config.
This was an attempt to maintain compatability.

added the related test specs for the new apply methods and updated the apply methods that changed.
Reklund3 added a commit to Reklund3/akka that referenced this issue Apr 3, 2020
@Reklund3
Add apply methods for typed ActorTestKit Javadsl (akka#27338) fix author
d9e9fb8
Reklund3 added a commit to Reklund3/akka that referenced this issue Apr 3, 2020
@Reklund3
Correcting apply method doc comments for Javadsl apply methods (akka#…
44c1542 
…27338) fix author
@patriknw patriknw added this to the 2.6.5 milestone Apr 8, 2020
@patriknw patriknw closed this as completed Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted help wanted Issues that the core team will likely not have time to work on t:testing t:typed
Projects
None yet
Milestone
2.6.5
Development

No branches or pull requests
3 participants
@patriknw @johanandren @Reklund3