Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Productionize CurrentShardRegionState #27406

Closed
helena opened this issue Jul 23, 2019 · 4 comments
Closed

Productionize CurrentShardRegionState #27406

helena opened this issue Jul 23, 2019 · 4 comments
Assignees
@helena
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted 3 - in progress Someone is working on this ticket nice-to-have (low-prio) Tasks which make sense, however are not very high priority, feel free to help out! t:cluster-sharding
Milestone
2.6.4

Comments

@helena
Copy link
Member

helena commented Jul 23, 2019 •
edited
Loading

Currently this is only used by tests and not added to the internal protobufs for users.
If this is ever bumped up to gathering from the ShardCoordinator or Akka Management HTTP cluster routes, this needs to be added to the protos and extend ClusterShardingSerializable, and with this #27395 merged it can also include the ShardId set of any that may have failed in the ask.
@helena helena added t:cluster-sharding discuss Tickets that need some discussion before proceeding. Not decided if it's a good idea. labels Jul 23, 2019
@chbatey
Copy link
Member

chbatey commented Jul 23, 2019

Sounds useful as this is a public type but doesn't seem a priority for 2.6/typed.

@chbatey chbatey added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted help wanted Issues that the core team will likely not have time to work on nice-to-have (low-prio) Tasks which make sense, however are not very high priority, feel free to help out! and removed discuss Tickets that need some discussion before proceeding. Not decided if it's a good idea. labels Jul 23, 2019
@helena
Copy link
Member Author

helena commented Jul 23, 2019

Agree, not important ATM, worth considering later.

@helena helena mentioned this issue Jul 24, 2019
Merged
@helena helena self-assigned this Feb 19, 2020
@helena helena added 3 - in progress Someone is working on this ticket and removed help wanted Issues that the core team will likely not have time to work on labels Feb 19, 2020
@patriknw patriknw mentioned this issue Feb 21, 2020
Closed
25 tasks
helena pushed a commit to helena/akka that referenced this issue Feb 25, 2020
Productionize CurrentShardRegionState akka#27406
d1a6572
@helena helena mentioned this issue Feb 25, 2020
Merged
helena pushed a commit to helena/akka that referenced this issue Feb 25, 2020
Productionize CurrentShardRegionState akka#27406
9e5747f
@helena helena mentioned this issue Feb 26, 2020
Open
helena added a commit that referenced this issue Feb 26, 2020
@helena
Productionize CurrentShardRegionState #27406 (#28645)
26c333b
@raboof
Copy link
Member

raboof commented Feb 27, 2020

Can this be closed now #28645 is merged?

@helena
Copy link
Member Author

helena commented Feb 27, 2020

It is merged, closing.

@helena helena closed this as completed Feb 27, 2020
@helena helena added this to the 2.6.4 milestone Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@helena helena

Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted 3 - in progress Someone is working on this ticket nice-to-have (low-prio) Tasks which make sense, however are not very high priority, feel free to help out! t:cluster-sharding
Projects
None yet
Milestone
2.6.4
Development

No branches or pull requests
3 participants
@raboof @helena @chbatey