Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add color to LogCapturing "Logging started" and "Logging finished" #31689

Closed
skestle opened this issue Oct 18, 2022 · 2 comments
Closed

Add color to LogCapturing "Logging started" and "Logging finished" #31689

skestle opened this issue Oct 18, 2022 · 2 comments
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted help wanted Issues that the core team will likely not have time to work on
Milestone
2.8.0-M1

Comments

@skestle
Copy link

skestle commented Oct 18, 2022

The default behavior is for LogCapturing to keep logs after each test (https://github.com/akka/akka/blob/main/akka-actor-testkit-typed/src/main/scala/akka/actor/testkit/typed/scaladsl/LogCapturing.scala#L55)

Since this is the case, it'd be really good to add a color to test start and end messages so we can at least easily see when the failed test started (and whether we might need to look back further) (https://github.com/akka/akka/blob/main/akka-actor-testkit-typed/src/main/scala/akka/actor/testkit/typed/scaladsl/LogCapturing.scala#L69)
@patriknw
Copy link
Member

I think there are pretty clear log messages indicating start and end, but I can understand that the visual aid would be useful.

PR would be welcome.

@patriknw patriknw added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted help wanted Issues that the core team will likely not have time to work on labels Oct 28, 2022
jackyscript added a commit to jackyscript/akka that referenced this issue Nov 5, 2022
@jackyscript
Add color to LogCapturing akka#31689
66899fd
@jackyscript jackyscript mentioned this issue Nov 5, 2022
Merged
@jackyscript
Copy link
Contributor

@patriknw please have a look at above pull request.

patriknw pushed a commit that referenced this issue Nov 15, 2022
@jackyscript
Add color to LogCapturing #31689 (#31719)
1dbf406
@patriknw patriknw added this to the 2.8.0-M1 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted help wanted Issues that the core team will likely not have time to work on
Projects
None yet
Milestone
2.8.0-M1
Development

No branches or pull requests
3 participants
@skestle @patriknw @jackyscript