Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color to LogCapturing #31689 #31719

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Conversation

jackyscript
Copy link
Contributor

References #31689

As this is my first time, I am happy for any feedback.

@lightbend-cla-validator
Copy link

Hi @jackyscript,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@jackyscript
Copy link
Contributor Author

Hi @jackyscript,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

Signed

Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (and verified locally that it does nicely color a fail), thanks @jackyscript !

@johanandren
Copy link
Member

Failure is formatting, please do a compile which will trigger reformat, and commit/push the changed file.

@jackyscript
Copy link
Contributor Author

jackyscript commented Nov 8, 2022

Failure is formatting, please do a compile which will trigger reformat, and commit/push the changed file.

@johanandren Done, now it looks formatted to me.

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@patriknw patriknw merged commit 1dbf406 into akka:main Nov 15, 2022
@jackyscript jackyscript deleted the color-log-capturing branch November 15, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants