=pro run multi-jvm tests when validating pr #17532

2m · 2015-05-20T16:48:57Z

The essence of this is one more autoplugin MultiNodeWithPrValidation that gets triggered on a project which has both MultiNode and ValidatePullRequest autoplugins enabled.

akka-ci · 2015-05-20T17:50:20Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.akka.io/job/pr-validator-per-commit-jenkins/2712/

akka-ci · 2015-05-20T17:56:31Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.akka.io/job/pr-validator-per-commit-jenkins/2711/

ktoso · 2015-05-20T18:36:07Z

project/package.scala

+
+  implicit class RichBoolean(val b: Boolean) extends AnyVal {
+    final def apply[A](a: => A): Option[A] = if (b) Some(a) else None
+  }


I would prefer to avoid such very broad conversions (on primitive type, providing an apply()), or if really needed define very near it's use-site.

It reduces boilerplate when used together with boolean flags that we have quite a few. Therefore it is not possible to add it to a narrower scope.

For example previously we had:

if (CliOption.sbtLogNoFormat) List("-Dakka.test.nocolor=true") else Nil

And now we have instead:

CliOption.sbtLogNoFormat("-Dakka.test.nocolor=true").toList

WDYT?

akka-ci · 2015-05-21T08:01:03Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.akka.io/job/pr-validator-per-commit-jenkins/2714/

ktoso · 2015-05-21T08:29:20Z

project/Unidoc.scala

+  val validateDiagrams = settingKey[Boolean]("Validate generated scaladoc diagrams")
+
+  val javadocSettings = if (CliOption.genjavadocEnabled) Seq(
+    scalacOptions in Compile += "-P:genjavadoc:fabricateParams=true",


This seems to be the failure culprit:

[error] bad option: -P:genjavadoc:fabricateParams=true

the same setting was used previously... so what's different here hm

@2m no need for genjavadocExtraSettings?

genjavadocExtraSettings was used before as well.

Sorry, the comment was supposed to be "need for genjavadocExtraSettings" it was there but now it's gone

(does not solve the bad option problem we're having though, so maybe a non issue)

akka-ci · 2015-05-21T11:37:39Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.akka.io/job/pr-validator-per-commit-jenkins/2717/

ktoso · 2015-05-21T12:24:42Z

LGTM, one nitpick about moving javadoc things out of the scaladoc plugin.

2m · 2015-05-27T13:47:16Z

Made dynamic task execution work with a bit of magic from http://stackoverflow.com/questions/24615783/combining-taskdyn-and-tags-in-sbt thanks to @jsuereth

akka-ci · 2015-05-27T15:07:41Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.akka.io/job/pr-validator-per-commit-jenkins/2761/

ktoso · 2015-05-27T15:16:11Z

Finally all green!

akka-ci · 2015-05-27T15:51:49Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.akka.io/job/pr-validator-per-commit-jenkins/2762/

rkuhn · 2015-05-27T15:54:56Z

LGTM

patriknw · 2015-05-28T09:08:50Z

LGTM

2m · 2015-05-28T09:13:37Z

Added one last commit which removed RootSettings autoplugin and also kept values from tasks to get rid of the

[warn] /home/martynas/projects/akka/project/ValidatePullRequest.scala:217: a pure expression does nothing in statement position; you may be omitting necessary parentheses
[warn]       validationTasks.map(taskKey => Def.task { taskKey.value; () } ).foldLeft(zero) { (acc, current) =>
[warn]

when compiling akka build.

Validated again that no additional tasks are run when project validation is skipped.

Will squash and merge after successful validation.

akka-ci · 2015-05-28T10:27:10Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.akka.io/job/pr-validator-per-commit-jenkins/2766/

* addunidoc task via an AutoPlugin that depends on PrValidation and Unidoc autoplugins * separate cli option logic to a case class * remove autoplugin for root project

akka-ci · 2015-05-28T12:05:57Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.akka.io/job/pr-validator-per-commit-jenkins/2769/

=pro run multi-jvm tests when validating pr

akka-ci added the validating PR is currently being validated by Jenkins label May 20, 2015

2m force-pushed the wip-pr-multi-jvm branch from cdb2b42 to 400fadf Compare May 20, 2015 16:54

akka-ci added validating PR is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR is currently being validated by Jenkins labels May 20, 2015

akka-ci added the needs-attention Indicates a PR validation failure (set by CI infrastructure) label May 20, 2015

ktoso reviewed May 20, 2015
View reviewed changes

ktoso mentioned this pull request May 20, 2015

PR Validation: minor changes on top of #17532 (should work now) #17535

Closed

2m force-pushed the wip-pr-multi-jvm branch from 400fadf to 65e3984 Compare May 21, 2015 07:47

ktoso reviewed May 21, 2015
View reviewed changes

2m force-pushed the wip-pr-multi-jvm branch from 65e3984 to 90b3ee6 Compare May 21, 2015 10:16

akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR is currently being validated by Jenkins labels May 21, 2015

ktoso mentioned this pull request May 21, 2015

=pro update sbt-jmh and include for compilation in root #17543

Merged

akka-ci added the validating PR is currently being validated by Jenkins label May 21, 2015

akka-ci added validating PR is currently being validated by Jenkins and removed tested PR that was successfully built and tested by Jenkins labels May 27, 2015

2m force-pushed the wip-pr-multi-jvm branch from 2fbc766 to f481e18 Compare May 27, 2015 14:31

akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels May 27, 2015

akka-ci added the tested PR that was successfully built and tested by Jenkins label May 27, 2015

akka-ci added validating PR is currently being validated by Jenkins and removed tested PR that was successfully built and tested by Jenkins labels May 28, 2015

akka-ci added needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR is currently being validated by Jenkins labels May 28, 2015

2m mentioned this pull request May 28, 2015

FAILED: akka.contrib.pattern.ReliableProxy #17599

Closed

=pro run multi-jvm tests when validating pr

7fc2790

* addunidoc task via an AutoPlugin that depends on PrValidation and Unidoc autoplugins * separate cli option logic to a case class * remove autoplugin for root project

2m force-pushed the wip-pr-multi-jvm branch from 349d476 to 7fc2790 Compare May 28, 2015 10:59

akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR is currently being validated by Jenkins labels May 28, 2015

2m added a commit that referenced this pull request May 28, 2015

Merge pull request #17532 from 2m/wip-pr-multi-jvm

0b15a8c

=pro run multi-jvm tests when validating pr

2m merged commit 0b15a8c into akka:master May 28, 2015

2m deleted the wip-pr-multi-jvm branch May 28, 2015 13:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

=pro run multi-jvm tests when validating pr #17532

=pro run multi-jvm tests when validating pr #17532

2m commented May 20, 2015

akka-ci commented May 20, 2015

akka-ci commented May 20, 2015

ktoso May 20, 2015

patriknw May 21, 2015

2m May 21, 2015

akka-ci commented May 21, 2015

ktoso May 21, 2015

ktoso May 21, 2015

ktoso May 21, 2015

2m May 21, 2015

ktoso May 21, 2015

ktoso May 21, 2015

akka-ci commented May 21, 2015

ktoso commented May 21, 2015

2m commented May 27, 2015

akka-ci commented May 27, 2015

ktoso commented May 27, 2015

akka-ci commented May 27, 2015

rkuhn commented May 27, 2015

patriknw commented May 28, 2015

2m commented May 28, 2015

akka-ci commented May 28, 2015

akka-ci commented May 28, 2015

=pro run multi-jvm tests when validating pr #17532

=pro run multi-jvm tests when validating pr #17532

Conversation

2m commented May 20, 2015

akka-ci commented May 20, 2015

akka-ci commented May 20, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akka-ci commented May 21, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akka-ci commented May 21, 2015

ktoso commented May 21, 2015

2m commented May 27, 2015

akka-ci commented May 27, 2015

ktoso commented May 27, 2015

akka-ci commented May 27, 2015

rkuhn commented May 27, 2015

patriknw commented May 28, 2015

2m commented May 28, 2015

akka-ci commented May 28, 2015

akka-ci commented May 28, 2015