=rem #17729 Don't use Implicits.global in remoting shutdown #17876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -146,6 +145,7 @@ private[remote] class Remoting(_system: ExtendedActorSystem, _provider: RemoteAc | |||
| endpointManager = None | |||
| } | |||
|
|
|||
| import system.dispatcher | |||
There was a problem hiding this comment.
is it still alive and kicking here?
There was a problem hiding this comment.
As far as I can see, it is. endpointManager is an actor.
I have verified (with printlns) that the callback is running with the system.dispatcher in all cases when running the tests in akka-remote.
There was a problem hiding this comment.
Yes, I think the caller of this shutdown() method actually blocks on an Await, so this is probably safe.
|
Refs #17729 |
|
Test PASSed. |
|
LGTM |
|
LGTM, nice detective work! |
ktoso
added a commit
that referenced
this pull request
Jul 3, 2015
=rem #17729 Don't use Implicits.global in remoting shutdown
ktoso
added a commit
to ktoso/akka
that referenced
this pull request
Jan 11, 2016
…triknw =rem akka#17729 Don't use Implicits.global in remoting shutdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have verified (with printlns) that the callback is running with the system.dispatcher in all cases when running the tests in akka-remote.