Wip 1530 detach futures from message dispatcher √ #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Creates an ExecutionContext from the given Executor | ||
| */ | ||
| def fromExecutor(e: ExecutorService): ExecutionContext = new WrappedExecutor(e) |
There was a problem hiding this comment.
two times the same argument type? I don’t really know much about this, but it smells fishy.
|
looks obvious enough, but I cannot confidently state that I looked deeply at the details. |
|
Alright, merging |
viktorklang
added a commit
that referenced
this pull request
Dec 30, 2011
…age-dispatcher-√ Wip 1530 detach futures from message dispatcher √
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need this reviewed ASAP so it can go into M2. Will merge it in a couple of hours unless someone stops me.