Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

str #19589 backport autoflushing in outputstream sink #20164

Merged
merged 1 commit into from
Apr 1, 2016
Merged

str #19589 backport autoflushing in outputstream sink #20164

merged 1 commit into from
Apr 1, 2016

Conversation

ktoso
Copy link
Member

@ktoso ktoso commented Mar 29, 2016

Manual backport of the auto flushing feature added in #19589
Just cherry picking is not as trivial since we introduced more things (IOResult etc).

@drewhk
Copy link
Member

drewhk commented Mar 29, 2016

But this changes the signature...

@drewhk drewhk added this to the stream-http-2.0.4 milestone Mar 29, 2016
@ktoso
Copy link
Member Author

ktoso commented Mar 29, 2016

Nope, it's safe, specifically adds overload with the additional boolean (instead of changing signature to use default param, which would be breaking), internal classes constructor param we don't guarantee anything about (though you're right MiMa will panic, I'll fix that).

@ktoso ktoso added the reviewed Ready to merge from review perspetive, but awaiting some additional action (e.g. order of merges) label Mar 29, 2016
@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins labels Mar 29, 2016
@akka-ci
Copy link

akka-ci commented Mar 29, 2016

Test PASSed.

@akka-ci akka-ci added needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins labels Mar 29, 2016
@akka-ci
Copy link

akka-ci commented Mar 29, 2016

Test FAILed.

@ktoso
Copy link
Member Author

ktoso commented Mar 29, 2016

Actual perhaps failure?

[info] - must fill up buffer by default *** FAILED *** (42 milliseconds)
[info]   Array(-5, -17, -126) did not equal Array(76, 49, 2) (InputStreamSinkSpec.scala:150)

@patriknw patriknw added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Mar 31, 2016
@drewhk
Copy link
Member

drewhk commented Apr 1, 2016

I believe this failure has nothing to do with the backport. @ktoso can you please rebase it? If after rebase validation passes, I opt for merging this.

@ktoso
Copy link
Member Author

ktoso commented Apr 1, 2016

rebased

@akka-ci akka-ci added validating PR is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR is currently being validated by Jenkins labels Apr 1, 2016
@akka-ci
Copy link

akka-ci commented Apr 1, 2016

Test FAILed.

@ktoso
Copy link
Member Author

ktoso commented Apr 1, 2016

Failure was unrelated #20197

@ktoso ktoso merged commit 66553c0 into akka:stream-http-2.0 Apr 1, 2016
@ktoso ktoso deleted the wip-flush-ktoso branch April 1, 2016 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding needs-attention Indicates a PR validation failure (set by CI infrastructure) reviewed Ready to merge from review perspetive, but awaiting some additional action (e.g. order of merges)
Projects
None yet
Milestone
stream-http-2.0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ktoso @drewhk @akka-ci @patriknw