Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def register(to: Future[U]) = to onComplete { | ||
| case r @ Right(_) ⇒ p tryComplete r | ||
| case l @ Left(_) ⇒ that.value match { | ||
| case Some(Left(_)) ⇒ p tryComplete l //If he failed, race for setting failure |
There was a problem hiding this comment.
It looks like it 'that' fails before 'this' succeeds the promise will be completed with the failure. Is this intentional, or should register take both futures as args (instead of hardcoding 'that')?
|
I've changed the semantics to cascade only failures. |
| val p = Promise[U]() | ||
| onComplete { | ||
| case r @ Right(_) ⇒ p complete r | ||
| case _ ⇒ that onSuccess { case r ⇒ p success r } |
There was a problem hiding this comment.
is it intentional that if that also fails, p is never completed? (I as a user would not expect that kind of behavior)
There was a problem hiding this comment.
What would you expect? The failure of the first, or of the second?
|
Can I merge now plz? |
|
u can haz me smiley: :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the flawed orElse and replacing it with the more awesomized "or".