Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glued Scala/Java code snippet tabs #23420

Merged
merged 1 commit into from
Jul 25, 2017

Conversation

richardimaoka
Copy link
Contributor

Refs #23415

Currently the "Graceful Stop" section looks as follows - four tabs in a row but there should be only two.

http://doc.akka.io/docs/akka/current/scala/actors.html#graceful-stop

image

Here's how it looks with this change:

https://richard-akka-doc.firebaseapp.com/scala/actors.html#graceful-stop
https://richard-akka-doc.firebaseapp.com/java/actors.html#graceful-stop

@akka-ci akka-ci added the validating PR is currently being validated by Jenkins label Jul 25, 2017
@@ -49,6 +49,7 @@
import akka.pattern.AskTimeoutException;
import scala.concurrent.duration.Duration;
import java.util.concurrent.CompletionStage;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inserting a line after the import statements for Java.

image

@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Jul 25, 2017
@akka-ci
Copy link

akka-ci commented Jul 25, 2017

Test PASSed.

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a difference 2 newlines can make :)

@raboof raboof merged commit 3b74128 into akka:master Jul 25, 2017
@jrudolph
Copy link
Member

Cool, thanks for the quick fix @richard-imaoka.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants