Scheduler that manually advances time #24243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
force-pushed
the
typed-tests-manually-advance-scheduler
branch
from
bbedcb2
to
d28c4c8
Compare
chbatey
reviewed
Jan 4, 2018
|
|
||
| class ManualTimerSpec extends TestKit() with ManualTime with WordSpecLike { | ||
| //#manual-scheduling-simple | ||
| "A timer" must { |
akka-ci
added
tested
|
Test PASSed. |
raboof
changed the title
johanandren
reviewed
Jan 5, 2018
| * For testing: scheduler that does not look at the clock, but must be progressed manually by calling `timePasses`. | ||
| * | ||
| * This is not entirely realistic: jobs will be executed on the test thread instead of using the `ExecutionContext`, but does | ||
| * allow for faster and less timing-sensitive specs.. |
There was a problem hiding this comment.
Couldn't we still have them run on whatever execution context they want through futures, but block time Passes on the futures completion?
There was a problem hiding this comment.
This would not really help, as the resulting behavior would still be different from what would happen when the jobs were executed in 'real time' parallel. I'll make the wording somewhat less scary.
akka-ci
added
validating
|
Test FAILed. |
akka-ci
added
validating
|
Test FAILed. |
akka-ci
added
validating
johanandren
reviewed
Jan 5, 2018
| * We will not add a dilation factor to this amount, since the scheduler API also does not apply dilation. | ||
| * If you want the amount of time passed to be dilated, apply the dilation before passing the delay to | ||
| * this method. | ||
| */ |
There was a problem hiding this comment.
"This will execute all outstanding jobs on the calling thread before returning" or such?
There was a problem hiding this comment.
👍. (It will also execute any jobs that are scheduled to be executed within the specified period by those outstanding jobs, but that might be a subtlety that doesn't really belong in the scaladoc here)
akka-ci
added
tested
|
Test PASSed. |
akka-ci
added
validating
|
Test PASSed. |
First version for review. More tests, docs and Java examples still TBD.
#24243 (comment) for some discussion on what to do instead
raboof
force-pushed
the
typed-tests-manually-advance-scheduler
branch
from
b261dd9
to
55c0faf
Compare
akka-ci
added
tested
|
Test PASSed. |
akka-ci
added
validating
|
Test PASSed. |
akka-ci
added
validating
|
Test PASSed. |
manonthegithub
pushed a commit
to manonthegithub/akka
that referenced
this pull request
Jan 31, 2018
* Don't apply dilation to scheduler parameter * Clarify ExecutionContext usage * Clarify comment on timePasses * Make ExplicitlyTriggeredScheduler internals private * List currently scheduled tasks in one log message * Execute immediately if (initialDelay <= Duration.Zero) * Don't reschedule if scheduled task fails * Be more efficient about logging * Widen `timePasses` delay for now akka#24243 (comment) for some discussion on what to do instead * Remove mechanism for mixing in config from a test trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24150
First version for early review. More tests, docs and Java examples still TBD.