Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more tests for receiving PoisonPill in various states, #24687 #26577

Merged
merged 1 commit into from
Mar 28, 2019
Merged

add more tests for receiving PoisonPill in various states, #24687 #26577

merged 1 commit into from
Mar 28, 2019
+79 −13

Conversation

patriknw
Copy link
Member

Refs #24687

@akka-ci akka-ci added the validating PR is currently being validated by Jenkins label Mar 20, 2019
@patriknw patriknw added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Mar 20, 2019
@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Mar 20, 2019
@akka-ci
Copy link

akka-ci commented Mar 20, 2019

Test PASSed.

helena
helena reviewed Mar 25, 2019
View reviewed changes
akka-persistence-typed/src/main/scala/akka/persistence/typed/internal/ReplayingEvents.scala Outdated
@@ -123,7 +123,8 @@ private[akka] final class ReplayingEvents[C, E, S](
private def onCommand(cmd: InternalProtocol): Behavior[InternalProtocol] = {
// during recovery, stash all incoming commands
if (state.receivedPoisonPill) {
if (setup.settings.logOnStashing) setup.log.debug("Discarding message [{}], because actor is to be stopped", cmd)
if (setup.settings.logOnStashing)
setup.log.debug("Discarding message [{}], because actor is to be stopped", cmd)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setup.log.debug("Discarding message [{}], because actor is to be stopped", cmd)
setup.log.debug("Discarding message [{}] because actor is to be stopped.", cmd)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, and a few more of the same kind

helena
helena reviewed Mar 25, 2019
View reviewed changes
akka-persistence-typed/src/main/scala/akka/persistence/typed/internal/ReplayingSnapshot.scala Outdated
else onCommand(cmd)
if (receivedPoisonPill) {
if (setup.settings.logOnStashing)
setup.log.debug("Discarding message [{}], because actor is to be stopped", cmd)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setup.log.debug("Discarding message [{}], because actor is to be stopped", cmd)
setup.log.debug("Discarding message [{}] because actor is to be stopped.", cmd)

helena
helena reviewed Mar 25, 2019
View reviewed changes
...nce-typed/src/test/scala/akka/persistence/typed/scaladsl/EventSourcedBehaviorStashSpec.scala
@@ -68,14 +73,16 @@ object EventSourcedBehaviorStashSpec {

final case class State(value: Int, active: Boolean)

def counter(persistenceId: PersistenceId): Behavior[Command[_]] =
def counter(persistenceId: PersistenceId, signalProbe: Option[ActorRef[String]] = None): Behavior[Command[_]] =
Copy link
Member

@helena helena Mar 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only ok with the default param because it's in a test.

helena
helena approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@helena helena left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 2 minor changes

@patriknw patriknw force-pushed the wip-24687-more-persistence-tests6-patriknw branch from 60bac1c to 980891c Compare March 26, 2019 13:50
@patriknw
Copy link
Member Author

will merge after validation

@akka-ci akka-ci added validating PR is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed tested PR that was successfully built and tested by Jenkins validating PR is currently being validated by Jenkins labels Mar 26, 2019
@akka-ci
Copy link

akka-ci commented Mar 26, 2019

Test FAILed.

@patriknw
Copy link
Member Author

PLS BUILD

@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR is currently being validated by Jenkins labels Mar 27, 2019
@akka-ci
Copy link

akka-ci commented Mar 27, 2019

Test PASSed.

@patriknw patriknw force-pushed the wip-24687-more-persistence-tests6-patriknw branch from 980891c to e6775d7 Compare March 27, 2019 15:22
@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR is currently being validated by Jenkins labels Mar 27, 2019
@akka-ci
Copy link

akka-ci commented Mar 27, 2019

Test PASSed.

@patriknw patriknw merged commit 02e68ab into master Mar 28, 2019
@patriknw patriknw deleted the wip-24687-more-persistence-tests6-patriknw branch March 28, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helena helena helena approved these changes

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patriknw @akka-ci @helena @johanandren