Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't put temporary actor refs in the heavy hitters table #30214

Merged

Conversation

johanandren
Copy link
Member

References #30212

Draft for now, I'll set up a repeater CI-multi-jvm-job to exercise it a bit.

@akka-ci akka-ci added validating PR is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR is currently being validated by Jenkins labels May 3, 2021
@akka-ci
Copy link

akka-ci commented May 3, 2021

Test FAILed.

@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR is currently being validated by Jenkins labels May 3, 2021
@akka-ci
Copy link

akka-ci commented May 3, 2021

Test PASSed.

@johanandren
Copy link
Member Author

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanandren
Copy link
Member Author

Mostly green builds for almost two weeks now, seen a couple of failures on the repeat job but haven't had time to investigate if they are related yet. I'll stop the job for now.

@johanandren
Copy link
Member Author

Looked at the few failed tests in repeat, nothing that looks related to this fix. 👍

@johanandren johanandren marked this pull request as ready for review May 25, 2021 11:56
@patriknw patriknw added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding tested PR that was successfully built and tested by Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants