Avoid submaterialization for lazy future and lazy single #31735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
reviewed
Nov 16, 2022
| @@ -534,7 +534,7 @@ object Source { | |||
| * the laziness and will trigger the factory immediately. | |||
| */ | |||
| def lazySingle[T](create: () => T): Source[T, NotUsed] = | |||
| lazySource(() => single(create())).mapMaterializedValue(_ => NotUsed) | |||
| single(()).map(_ => create()).withAttributes(DefaultAttributes.lazySingle) | |||
He-Pin
reviewed
Nov 16, 2022
| val f = create() | ||
| future(f) | ||
| }.mapMaterializedValue(_ => NotUsed) | ||
| single(()).mapAsyncUnordered(1)(_ => create()).withAttributes(DefaultAttributes.lazyFuture) |
There was a problem hiding this comment.
single(create).mapAsync(1)(_())?
There was a problem hiding this comment.
We optimize away mapAsync(1) to unordered behind the scenes since that is cheaper, so this just shortcuts directly there.
|
close-reopen to retrigger full CI |
pvlugter
approved these changes
Nov 17, 2022
johanandren
deleted the
wip-31733-avoid-materialization-for-future-source
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #31729
Same benefit as #31733 but by removing code instead of adding more.
Also covers lazySingle and corresponding methods in Java DSL.