Preparations for external transport of replicated events #31771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
johanandren
commented
Nov 29, 2022
johanandren
commented
- Ack protocol for the events being consumed
- A factory method to create replicated es entities without journal trailing through persistence query
patriknw
reviewed
Nov 30, 2022
akka-persistence-typed/src/main/scala/akka/persistence/typed/internal/Running.scala
Outdated
Show resolved
Hide resolved
akka-persistence-typed/src/main/scala/akka/persistence/typed/internal/Running.scala
Outdated
Show resolved
Hide resolved
johanandren
force-pushed
the
wip-replicated-es-transport-switch-prep
branch
from
a5c30e1
to
88ff9e7
Compare
pvlugter
approved these changes
Dec 1, 2022
...ersistence-typed/src/main/scala/akka/persistence/typed/javadsl/ReplicatedEventSourcing.scala
Outdated
Show resolved
Hide resolved
...rsistence-typed/src/main/scala/akka/persistence/typed/scaladsl/ReplicatedEventSourcing.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Peter Vlugter <pvlugter@users.noreply.github.com>
patriknw
approved these changes
Dec 22, 2022
| setup.internalLogger.warn("Received published event for [{}] but with no replicated metadata, dropping") | ||
| setup.internalLogger.warn( | ||
| "Received published event for [{}] but with no replicated metadata, dropping", | ||
| event.persistenceId) |
...ersistence-typed/src/main/scala/akka/persistence/typed/javadsl/ReplicatedEventSourcing.scala
Outdated
Show resolved
Hide resolved
.../src/main/scala/akka/persistence/typed/serialization/ReplicatedEventSourcingSerializer.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.