feat: convenience factories for Scala Try to StatusReply transform #31783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
changed the title
He-Pin
reviewed
Dec 8, 2022
| * | ||
| * Also note that Akka does not contain pre-build serializers for arbitrary exceptions. | ||
| */ | ||
| def fromTryKeepException[T](aTry: Try[T]): StatusReply[T] = new StatusReply(aTry) |
There was a problem hiding this comment.
Just calling it status could work, same as the Try in the StatusReply itself.
pvlugter
approved these changes
Dec 12, 2022
ennru
approved these changes
Dec 13, 2022
| def fromTryKeepException[T](aTry: Try[T]): StatusReply[T] = new StatusReply(aTry) | ||
|
|
||
| /** | ||
| * Scala API: Turn a try into a status reply. |
There was a problem hiding this comment.
Suggested change
| * Scala API: Turn a try into a status reply. | |
| * Scala API: Turn a Try into a status reply. |
Co-authored-by: Enno Runne <458526+ennru@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.