IOManager: support setting socket options #440
Conversation
Note: This is not backwards compatible and should only be included in 2.1
| * @param socketOwner the [[akka.actor.ActorRef]] that should receive events | ||
| * associated with the SocketChannel. The ActorRef for the | ||
| * current Actor will be used implicitly. | ||
| * @return a new SocketHandle that can be used to perform actions on the | ||
| * new connection's SocketChannel. | ||
| */ | ||
| def accept()(implicit socketOwner: ActorRef): SocketHandle = { | ||
| def accept(options: Seq[SocketOption])(implicit socketOwner: ActorRef): SocketHandle = { |
There was a problem hiding this comment.
default argument with Seq.empty and remove the accept overload?
|
What's the status Sean? |
|
Sorry, rather busy day at work yesterday sRp
|
|
No worries, let me know when it's ready for prime-time and the CLA is signed so I can move it into master. Great job! |
|
Signed cla yesterday
|
|
Alright, I'm merging in this now. |
IOManager: support setting socket options
Note: This is not backwards compatible and should only be included in 2.1
This is a potential fix for: https://www.assembla.com/spaces/akka/tickets/2048