Changing the default sender of ! to be Actor.noSender to keep null in on... #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… one place and have a logical alternative when deadLetters isn't present in scope.
…it is indeed the famous null being used here.
| * Default placeholder (null) used for "!" to indicate that there is no sender of the message, | ||
| * that will be translated to the receiving system's deadLetters. | ||
| */ | ||
| final val noSender: ActorRef = null |
There was a problem hiding this comment.
It is a tad sad, though, that this cannot be made a compiler constant (I tried some variations but couldn’t get it to work).
There was a problem hiding this comment.
Not even the Klang could pull that off. :/
|
LGTM |
viktorklang
added a commit
that referenced
this pull request
Oct 8, 2012
Changing the default sender of ! to be Actor.noSender to keep null in on...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...e place and have a logical alternative when deadLetters isn't present in scope.