2.1: fix sometimes-off-by-one in PeekMailbox, see #2851 #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Started jenkins job akka-pr-validator at https://jenkins.akka.io/job/akka-pr-validator/249/ |
|
jenkins job akka-pr-validator: Success - https://jenkins.akka.io/job/akka-pr-validator/249/ |
| @@ -40,15 +40,15 @@ class PeekMailboxExtension(val system: ExtendedActorSystem) extends Extension { | |||
| class PeekMailboxType(settings: ActorSystem.Settings, config: Config) extends MailboxType { | |||
| override def create(owner: Option[ActorRef], system: Option[ActorSystem]) = (owner, system) match { | |||
| case (Some(o), Some(s)) ⇒ | |||
| val tries = config.getInt("max-tries") ensuring (_ >= 1, "max-tries must be at least 1") | |||
| val mailbox = new PeekMailbox(o, s, tries) | |||
| val retries = config.getInt("max-retries") ensuring (_ >= 1, "max-retries must be at least 1") | |||
There was a problem hiding this comment.
Don't we normally use ConfigExceptions for this?
There was a problem hiding this comment.
yes, or IllegalArgumentException (possibly via requires)
ensuring throws assertion error, which was the reason for https://www.assembla.com/spaces/akka/simple_planner#/ticket:2798
There was a problem hiding this comment.
ah, yes, of course, my bad; will fix
|
Aside from comment: LGTM! |
|
LGTM |
rkuhn
added a commit
that referenced
this pull request
Dec 21, 2012
2.1: fix sometimes-off-by-one in PeekMailbox, see #2851
|
👍 After the fact |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.