Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[s3] Timestamp (new-year's) bug in multipart upload #680

Closed
l15k4 opened this issue Dec 31, 2017 · 21 comments
Closed

[s3] Timestamp (new-year's) bug in multipart upload #680

l15k4 opened this issue Dec 31, 2017 · 21 comments
Labels
Milestone

Comments

@l15k4
Copy link

l15k4 commented Dec 31, 2017

I cannot really find how time is obtained when uploading to s3, but I get this error :

<Code>RequestTimeTooSkewed</Code><Message>The difference between the request time and the current time is too large.</Message><RequestTime>20181231T090017Z</RequestTime><ServerTime>2017-12-31T09:00:18Z</ServerTime>

On the last day of 2017. The system time on the machine is correct, I'm using openjdk:8 docker image.
I tried everything I could think of but no success.

@francisdb
Copy link
Contributor

We are also having problems, all our requests fail with 403 or the above one since this morning

@Derya
Copy link

Derya commented Dec 31, 2017

S A M E
A
M
E

@francisdb
Copy link
Contributor

francisdb commented Dec 31, 2017

There is a PR that fixes this by @guersam #679
Looks like we will have to wait for new year to get this fixed :-s

@lanastazia
Copy link

We are also impacted by this problem, so the urgent release is welcome

@ngbinh
Copy link

ngbinh commented Dec 31, 2017

Same issues here

@aakldey
Copy link

aakldey commented Dec 31, 2017

same

@teldosas
Copy link

Alright we're impacted by this too, I used jitpack.io to use directly the fix from the PR. Everything seems to work fine now 🎉 !

@aakldey
Copy link

aakldey commented Dec 31, 2017

@teldosas can you provide your dependency string? It doesn't work for me

@teldosas
Copy link

"com.github.swarms" % "alpakka" % "new-year-11-SNAPSHOT" I redid it for v0.11 which is the one I need

@teldosas
Copy link

don't forget to add resolvers += "jitpack" at "https://jitpack.io"

for the branch in the PR it would be "com.github.guersam" % "alpakka" % "tmp~s3-year-of-era-SNAPSHOT"

@aakldey
Copy link

aakldey commented Dec 31, 2017

@teldosas it says Note: Unresolved dependencies path: [warn] com.github.guersam:alpakka:tmp~s3-year-of-era-SNAPSHOT (/opt/atlassian/pipelines/agent/build/build.sbt#L35-36) [warn] +- traktrain:traktrain_2.12:2.6.x

@AbdelRahmanSalah
Copy link

@teldosas the same @aakldey issue

@teldosas
Copy link

teldosas commented Dec 31, 2017

https://jitpack.io/com/github/guersam/alpakka/tmp~s3-year-of-era-v0.15-g419a5b5-32/build.log it seems that jitpack.io is having trouble with the specific branch. It worked for me with the [other one]
(#680 (comment)).

@AbdelRahmanSalah
Copy link

thanks for you replay but I add
"com.github.swarms" % "alpakka" % "new-year-11-SNAPSHOT" and resolvers += "jitpack" at "https://jitpack.io"

but still get

::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	::          UNRESOLVED DEPENDENCIES         ::
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	:: com.github.swarms#alpakka;new-year-11-SNAPSHOT: not found
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::

@teldosas
Copy link

Hmm, that's weird, this thing exactly worked for me. As a last guess I would say to make sure that resolvers is before libraryDependencies (without being sure that it matters)

@ktoso
Copy link
Member

ktoso commented Dec 31, 2017

Posting "same" is not helping get things solved ;-)
Thanks @guersam for providing a fix, in #679 that's very helpful.
I'm looking into it.

@ktoso ktoso changed the title [s3] Timestamp bug in multipart upload [s3] Timestamp (new-year's) bug in multipart upload Dec 31, 2017
@ktoso ktoso added this to the 0.16 milestone Dec 31, 2017
@ktoso ktoso added the bug label Dec 31, 2017
@ktoso
Copy link
Member

ktoso commented Dec 31, 2017

Merged the fix and will attempt to release, thanks again @guersam for stepping up with the fix :-)

@ktoso ktoso closed this as completed Dec 31, 2017
@ktoso ktoso modified the milestones: 0.16, 0.15.1 Dec 31, 2017
@ktoso
Copy link
Member

ktoso commented Dec 31, 2017

The 0.15.1 version containing only this fix will shortly arrive on Maven Central.
Thanks again for reporting and fixing this together as a community :-)

https://github.com/akka/alpakka/releases/tag/v0.15.1

Happy new years'!

@ngbinh
Copy link

ngbinh commented Dec 31, 2017

Thanks

@l15k4
Copy link
Author

l15k4 commented Dec 31, 2017

Wow, nice catch :

YYYYMMdd'T'HHmmssX

vvvv

yyyyMMdd'T'HHmmssX

I reviewed this code but I didn't catch that. Thank you @francisdb, Happy new year !!!

@francisdb
Copy link
Contributor

Thanks go to @guersam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants