Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch: Add CreteCreateMessage which supports Elasticsearch op_type 'create' #1510

Merged
merged 3 commits into from
Feb 18, 2019
Merged

Conversation

danelkotev
Copy link
Contributor

@danelkotev danelkotev commented Feb 16, 2019

op_type that can be used to force a create operation, allowing for "put-if-absent" behavior. When create is used, the index operation will fail if a document by that id already exists in the index.

Pull Request Checklist

Fixes

Fixes #xxxx

Purpose

Add op_type 'create' which index only if not exists.

Background Context

Adding missing Elasticsearch supported option to create a document only if not exists.

References

https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-index_.html

…new document and if already exists, an error should be raised
@danelkotev danelkotev changed the title Add CreteCreateMessage which supports Elasticsearch option to create … Add CreteCreateMessage which supports Elasticsearch op_type 'create' Feb 16, 2019
@danelkotev danelkotev changed the title Add CreteCreateMessage which supports Elasticsearch op_type 'create' Elasticsearch: Add CreteCreateMessage which supports Elasticsearch op_type 'create' Feb 16, 2019
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition. Just some other wording as "raising an error" sounds more like an exception being thrown.

docs/src/main/paradox/elasticsearch.md Outdated Show resolved Hide resolved
Co-Authored-By: danelkotev <35635831+danelkotev@users.noreply.github.com>
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru merged commit 704a7a6 into akka:master Feb 18, 2019
@ennru
Copy link
Member

ennru commented Feb 18, 2019

Thank you for your contribution!

@ennru ennru added this to the 1.0-M3 milestone Feb 18, 2019
@tomerbendror
Copy link

Hi,

Just wanted to ask if you already known what the target release the next version

Thanks, Tomer

@ennru
Copy link
Member

ennru commented Feb 21, 2019

The release train has left the station: #1516
Expected arrival mid next week.

It includes a major make-over of Alpakka Elasticsearch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants