HBase: version 1.4.9 #1654
Merged
HBase: version 1.4.9 #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to be careful when upgrading versions to keep binary compatibility and might need to defer it to a non-patch release. |
ennru
reviewed
May 14, 2019
project/Dependencies.scala
Outdated
| Seq( | ||
| libraryDependencies ++= Seq( | ||
| // for some reason version 2.2.3U1 started to get picked which was not accepted by Whitesource) | ||
| "com.sun.xml.bind" % "jaxb-impl" % "2.2.3-1", // CDDL + GPLv2 | ||
| // TODO: remove direct dependency ^^ when updating from these very old versions |
There was a problem hiding this comment.
Can the direct jaxb-impl dependency go away now?
There was a problem hiding this comment.
I removed the jaxb-impl dependency. HBase tests are OK, but UnixDomainSocketSpec is failing somehow.
There was a problem hiding this comment.
No worries about UnixDomainSocket.
Does it still depend on jaxb-impl? What version?
There was a problem hiding this comment.
HBase 1.4.9 includes jaxb-impl 2.2.3-1
|
We upgraded some dependencies in test scope already. Can you rebase this and resolve the conflicts, please? |
probot-autolabeler
bot
added
the
dependency-change
|
I rebased this branch on current master. |
|
Failure was #1801 |
|
Thank you for this upgrade! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This change is to upgrade Apache HBase to 1.4.9, which is the current stable version.
Changes
This PR changed an HBase docker image to run tests using HBase 1.4.