Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDb: set 443 as default port #1724

Merged
merged 1 commit into from
May 24, 2019
Merged

Conversation

ennru
Copy link
Member

@ennru ennru commented May 23, 2019

Purpose

By defaulting to port 443 in reference.conf this makes #1722 work backwards-compatible.

Background Context

As tls was enabled by default, with just #1722 the code would try to connect to port -1. By making port 443 the default everything should work as previously.

@ennru ennru added this to the 1.0.2 milestone May 23, 2019
Copy link
Member

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ennru ennru merged commit f5e9a1c into akka:master May 24, 2019
@ennru ennru deleted the dynamoDb-443-default branch May 24, 2019 06:31
cheleb pushed a commit to cheleb/alpakka that referenced this pull request Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants