Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamoDb: set port from settings even when tls=true #1722

Merged
merged 1 commit into from
May 23, 2019
Merged

DynamoDb: set port from settings even when tls=true #1722

merged 1 commit into from
May 23, 2019

Conversation

mavericksid
Copy link
Contributor

Purpose

Fixes the issue wherein setting tls=true in DynamoSettings overwrites the configured port to 443

References

References #1662

Changes

Passed port to Http().cachedHostConnectionPoolHttps

@mavericksid mavericksid mentioned this pull request May 23, 2019
Closed
@ennru ennru changed the title fixed issue wherein setting tls=true in DynamoSettings overwrites the… DynamoDb: set port from settings even when tls=true May 23, 2019
2m
2m approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2m 2m added this to the 1.0.2 milestone May 23, 2019
@2m 2m merged commit eda595d into akka:master May 23, 2019
@2m
Copy link
Member

2m commented May 23, 2019

Thanks for the fix!

@mavericksid
Copy link
Contributor Author

Glad it helped!

@ennru ennru mentioned this pull request May 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2m 2m 2m approved these changes

Assignees
No one assigned
Labels
p:dynamodb
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mavericksid @2m @ennru