Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cassandra: add methods for new actors API (Akka 2.6.4) #2195

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

ennru
Copy link
Member

@ennru ennru commented Mar 13, 2020

Complement the CassandraSessionRegistry extension with access methods for ClassicActorSystemProvider which makes it usable without changed for the new actors API's akka.actor.typed.ActorSystem without depending on that module.

This can't be compiled against Akka 2.6 as ExtensionId in that version contains the apply(ClassicActorSystemProvider) method so it requires an override modifier in CasssandraSessionRegistry.

Use the SystemMaterializer to get hold of a Materializer.

Upgrades to Akka 2.6.4 and Akka 2.5.30.

See #2194

@probot-autolabeler probot-autolabeler bot added dependency-change For PRs changing the version of a dependency. p:cassandra labels Mar 13, 2020
@ennru ennru requested a review from patriknw March 13, 2020 12:30
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

project/Dependencies.scala Show resolved Hide resolved
@ennru ennru force-pushed the cassandra-classic-vs-typed branch from ba7e9ab to 2186c54 Compare March 17, 2020 06:50
@ennru ennru changed the title Cassandra: add methods for new actors API (Akka 2.5.30) Cassandra: add methods for new actors API (Akka 2.6.4) Mar 17, 2020
@ennru ennru merged commit 1a49144 into akka:master Mar 17, 2020
@ennru ennru deleted the cassandra-classic-vs-typed branch March 17, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-change For PRs changing the version of a dependency. p:cassandra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants