ActorSystemSpec

[rogeralsing]

Port the ActorSystemSpec.scala to C#
(Download the Scala source code from https://github.com/akka/akka)

[alkondrashov]

I*d like to help out here. Is it ok if I work on this one?

[rogeralsing]

Absolutely, go for it! :)

[alkondrashov]

there is ActorSystemSpec.cs already in repository. However ActorSystemSpec.scala is slightly different. Should ActorSystemSpec.cs be merged/overwritten according to scala*s version or left as it is?

[Danthar]

Is this still an active issue ?

[Aaronontheweb]

Our version should be updated to include all of the specs found in the Scala version. @alex-kondrashov or @Silv3rcircl3 or @Danthar, would any of you like to:

1. Verify that we've ported all of the specs and close out this issue or
2. Finish porting those specs and then close out the issue?

[marcpiechura]

I will give it a try.

[Aaronontheweb]

Ty sir

[marcpiechura]

This is what I found

Scala implementation	.Net implementation
use scala.concurrent.Future's InternalCallbackEC	Is implemented
reject invalid names	Is implemented
allow valid names	Is implemented
support extensions	Is implemented
handle extensions that fail to initialize	Not implemented yet Implemented via #1633
log dead letters	I think is implemented in DeathWatchSpec
run termination callbacks in order	I think is not implemented, furthermore I couldn't find any reference of RegisterOnTermination in the ActorSystem although it is referenced in the Shutdown summary Is implemented via #1523
awaitTermination after termination callbacks	See previous Is implemented via #1523
return isTerminated status correctly	IsTerminated doesn't exist in the ActorSystem, only in the context of an Actor this is already marked as depreacted
throw RejectedExecutionException when shutdown	Also uses the RegisterOnTermination callback and I couldn't find the RejectedExecutionException Is implemented via #1523
reliably create waves of actors	Not implemented yet Implemented via #1633
find actors that just have been created	Not implemented yet Implemented via #1633
reliable deny creation of actors while shutting down	Not implemented yet Implemented via #1633
shut down when /user fails	I think is implemented in SystemGuardianTests
allow configuration of guardian supervisor strategy	Seems to be not implemented at all, there are two TODO's for this. implemented via #1525
shut down when /user escalates	Needs to change the guardian-supervisor-strategy, so can only implemented if the previous one is implemented implemented via #1525
work with a passed in ExecutionContext	it's not possible to pass in a custom dispatcher, he only can be set via configuration
not use passed in ExecutionContext if executor is configured	it's not possible to pass in a custom dispatcher, he only can be set via configuration
not allow top-level actor creation with custom guardian	I don't know if it is possible to use a custom guardian

[marcpiechura]

Last pending PR has been merged and all possible tests are implemented