Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Akka IO: ByteIterator and ByteStringbuilder bug fixes #1682

Merged
merged 1 commit into from
Feb 1, 2016
Merged

Akka IO: ByteIterator and ByteStringbuilder bug fixes #1682

merged 1 commit into from
Feb 1, 2016

Conversation

fergusn
Copy link
Contributor

@fergusn fergusn commented Feb 1, 2016

Minor bug fixes for Akka IO

@Horusiath
Copy link
Contributor

@willieferguson could you describe this issue a little bit more? For the sake of future generations :P

@fergusn
Copy link
Contributor Author

fergusn commented Feb 1, 2016

Sure:

  1. This was a copy/paste bug: The code cast an integer to a short, which throws when the number is larger than a short.
  2. Convert.ToByte throws an Overflow exception if the argument is larger than Byte.MaxValue, which is not what we want in this case.

@Horusiath
Copy link
Contributor

👍

Horusiath added a commit that referenced this pull request Feb 1, 2016
@Horusiath
Merge pull request #1682 from willieferguson/akka-io-bugs
9087c7b 
Akka IO: ByteIterator and ByteStringbuilder bug fixes
@Horusiath Horusiath merged commit 9087c7b into akkadotnet:dev Feb 1, 2016
This was referenced Apr 6, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fergusn @Horusiath @Aaronontheweb