Wrap user stash to avoid confusion between PersistentActor.UnstashAll… #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All of your recent PRs are failing this test: #1762 |
| _internalStash.Prepend(ClearStash()); | ||
| } | ||
|
|
||
| public void UnstashAll(Func<Envelope, bool> predicate) |
There was a problem hiding this comment.
Isn't this a little confusing? I mean, this stash consists of two internally, and while parameterless UnstashAll method is working on internal stash, the one with predicate works only with user stash. Maybe we should name them in a way, that is more informative about their purpose.
There was a problem hiding this comment.
@Horusiath this matches the akka jvm, where unstashAll overrides method from super. As I mentioned, I do find it 'not ideal'. If anything, I would throw in the wrapped 'Unstash' and 'UnstashAll(predicate)', and reserve the use to subclasses.
There was a problem hiding this comment.
Ok. Lets settle on that.
… and PersistentActor.Stash.UnstashAll
Horusiath
added a commit
that referenced
this pull request
Mar 11, 2016
…-persistent-actors Wrap user stash to avoid confusion between PersistentActor.UnstashAll…
cconstantin
deleted the
remove-confusing-UnstashAll-in-persistent-actors
branch
This was referenced Apr 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and PersistentActor.Stash.UnstashAll
I do find it fascinating (for lack of a better word) that
Unstash()andUnstashAll(predicate)do not get the same treatment asUnstashAll(), i.e. prepending the user stash messages to the_internalStash. It may come up in the future.