[WIP] Akka.IO and Streams update #2405

Horusiath · 2016-12-08T13:13:50Z

DO NOT MERGE: work in progress

This is work I took over from @willieferguson on the akka-io branch. This PR contains new design of akka.io - without previous abstractions in form of socket channels. It's working directly on SocketAsyncEventArgs not and should be compatible with .NET Standard 1.3+ (no BeginXXX and EndXXX methods anymore).

Once I'll fix them, I'll remove WIP marker.
/cc #2153

Horusiath · 2017-01-14T19:32:58Z

Looks like Mono build doesn't specify MONO compile flag - therefore compilation chain fails on IPAddress.MapToIPv4 as it's not implemented on Mono.

alexvaluyskiy · 2017-01-14T21:09:34Z

Just move this extension method to Akka.Core package

akka.net/src/core/Akka.Remote/IPExtensions.cs

Line 42 in 103d5d0

public static IPAddress MapToIPv4(this IPAddress ipa)

Horusiath · 2017-01-14T21:18:36Z

@alexvaluyskiy I've moved it and since it's using reflection, I've added conditional flag to use it only for mono (#if MONO), and use normal .NET API on remaining platforms. But it looks like the MONO flag is not set when building on linux-mono agent.

alexvaluyskiy · 2017-01-15T08:53:31Z

@Horusiath change this line https://github.com/akkadotnet/akka.net/blob/dev/build.fsx#L26 to this
let configuration = if isMono then "Release" else "Release Mono"

Horusiath · 2017-01-15T09:03:57Z

Thanks (the condition should be reversed IMO ;) ).

alexvaluyskiy · 2017-01-16T19:01:07Z

@Horusiath It is not necessary to use #MONO flag here. You can stay with extension method (with reflection inside). The extension method never execute if there is the original method with the same signature.

Horusiath · 2017-01-16T19:10:48Z

@alexvaluyskiy

The extension method never execute if there is the original method with the same signature.

The current impl has that shape, because mono build was blowing up when I left this as an extension method before.

Aaronontheweb · 2017-01-17T17:47:03Z

Looks like the Mono build is still having trouble on this PR.


[09:13:43]	./build.sh: line 13: wget: command not found
[09:13:43]	Cannot open assembly '/checkout/src/.nuget/nuget.exe': No such file or directory.
[09:14:31]	Running build failed.
[09:14:31]	Error:
[09:14:31]	Building /checkout/src/Akka.sln failed with exitcode 1.
[09:14:31]	Status:           Failure
[09:14:31]	  1) Building /checkout/src/Akka.sln failed with exitcode 1.
[09:14:31]	  2) CS1061: IO/IPExtensions.cs(28,65): Type `System.Net.IPAddress' does not contain a definition for `MapToIPv4' and no extension method `MapToIPv4' of type `System.Net.IPAddress' could be found. Are you missing an assembly reference?
[09:14:31]	  3) CS1061: IO/IPExtensions.cs(31,65): Type `System.Net.IPAddress' does not contain a definition for `MapToIPv6' and no extension method `MapToIPv6' of type `System.Net.IPAddress' could be found. Are you missing an assembly reference?
[09:14:31]	
[09:14:35]	Process exited with code 42

Horusiath · 2017-02-13T05:38:39Z

Missing parts, I'm working on:

Failing linux/mono tests - I've fixed most of them locally (by default creating Socket on Mono assigns it an AddressFamily.InterNetworkV6... which is not supported by Mono itself).
There are some other tests failing on linux/mono for reason I don't know.
I've created a stress test similar in mind to Helios horizontal scale test... but it can boil down my comp. Not sure why yet.

alexvaluyskiy · 2017-03-02T17:42:50Z

@Horusiath should this https://github.com/Horusiath/akka.net/blob/akka-io/src/core/Akka/IO/SimpleDnsManager.cs#L56 returns true?

Horusiath · 2017-03-10T17:53:58Z

It looks like the current issues on linux/mono environment will block this PR, and we cannot do much about: https://bugzilla.xamarin.com/show_bug.cgi?id=53229

alexvaluyskiy · 2017-03-10T18:18:40Z

Could we temporary skip that tests on Mono. And create a know issue.

alexvaluyskiy · 2017-05-03T05:16:33Z

src/core/Akka/Util/ByteHelpers.cs

+
+namespace Akka.Util
+{
+    public static class ByteHelpers


Why public?

Horusiath · 2017-05-03T09:40:22Z

I've implemented IsMatch(ByteString substring, int fromIndex) method to optimize case when we check if substring starting from given index matches given one. This was pretty intensive case in Framing class, and it was using something like Equals(x.Slice(possibleMatch, y.Count), y) which was allocating way more objects than necessary. This version doesn't allocate any heap objects, it's just plain while loops.

…adotnet#2622) * added FAKE task to build proto files * Added ClusterMessages protobuf3 serializer * Added protobuf3 serialization to ClusterTools * fix cluster serializer * Made protobuf classes internal * Added nbench spec for serialization * update protobuf dependency in the projects * Added sharding serializer * fix serialization

* migrated akka.remote to protobuf3 * ported Akka.Remote.* to protobuf3, reverted src\core\protobuf content and moved new stuff to src\core\protobuf3 folder * fixed serialization tests (handled TODOs left for myself) * removed redundant ConnectionAssiciation.cs file from AkkaIO folder * remote protobuf3 folder * fix API * fix API 2

…kadotnet#2623) Protobuf3 serializers for system messages and for primitive types

Protobuf3 Netcore

* Converted Akka.NET project to NetStandard

Aaronontheweb · 2017-05-09T15:17:15Z

cc @alexvaluyskiy doesn't this need to target the v1.3 branch going forward now?

alexvaluyskiy · 2017-05-09T15:41:04Z

@Aaronontheweb yes, it should target v1.3

…adotnet#2661)

* temporarily ignore Persistence.Tests due to OutOfMemoryException * switch to dotnet-xunit and upgrade to xunit 2.3.0 beta * formatting by vs * tests already build so no need for build dependency * straggling commented out code from local tests * make windows tests pass with xunit 2.3.0 * skip snapshotstorespec on Linux, but still run on mono * skip Persistence.Sqlite.Tests temporarily * set back to original compiler directive based skip tests

This PR updates the docfx configuration file to support .netStandard project files.

Enable performance tests on Windows/.NET Framework

This PR fixes a number of spelling typos, a number of copyright headers, replaces various bits with <inheritdoc/>, and fills in more TBD placeholders.

Horusiath added akka-io akka-streams WIP labels Dec 8, 2016

Aaronontheweb added the needs review label Dec 8, 2016

Horusiath force-pushed the akka-io branch from 7054ba1 to 00eb888 Compare December 9, 2016 10:03

Horusiath mentioned this pull request Dec 14, 2016

Performance/stress tests for Akka.IO #2414

Open

Horusiath force-pushed the akka-io branch 3 times, most recently from 711ef36 to c917439 Compare January 14, 2017 16:04

Horusiath force-pushed the akka-io branch from df979c6 to 53577dd Compare January 15, 2017 09:03

Horusiath force-pushed the akka-io branch from 53577dd to 6dcf89e Compare January 15, 2017 09:10

Horusiath force-pushed the akka-io branch 2 times, most recently from 607bfdf to 5085539 Compare February 7, 2017 19:55

Horusiath force-pushed the akka-io branch 2 times, most recently from 53028a4 to 701765f Compare February 21, 2017 21:11

Horusiath force-pushed the akka-io branch from 701765f to ec41adb Compare February 26, 2017 18:51

alexvaluyskiy mentioned this pull request Feb 27, 2017

[WIP] Support for NetStandard 1.6 #2532

Closed

Horusiath force-pushed the akka-io branch from ec41adb to ae28a0d Compare March 11, 2017 09:00

alexvaluyskiy reviewed May 3, 2017

View reviewed changes

src/core/Akka/Util/ByteHelpers.cs

namespace Akka.Util

{

public static class ByteHelpers

Copy link

Contributor

alexvaluyskiy May 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why public?

alexvaluyskiy and others added 5 commits May 5, 2017 12:33

Protobuf3 serializers for system messages and for primitive types (ak…

7db9987

…kadotnet#2623) Protobuf3 serializers for system messages and for primitive types

Added SystemMessagesSerializer and Protobuf serializer (akkadotnet#2629)

8be5e64

Merge pull request akkadotnet#2645 from alexvaluyskiy/protobuf3netcore

1086b77

Protobuf3 Netcore

alexvaluyskiy mentioned this pull request May 6, 2017

NetCore meta-issue / Status #2153

Closed

18 tasks

Support for NetStandard 1.6 (akkadotnet#2647)

53858e9

* Converted Akka.NET project to NetStandard

Horusiath force-pushed the akka-io branch 2 times, most recently from 58b2d68 to cf350af Compare May 9, 2017 19:41

alexvaluyskiy and others added 5 commits May 11, 2017 17:16

allow build on mono (akkadotnet#2656)

5aebe13

temporarily ignore Persistence.Tests due to OutOfMemoryException (akk…

31e0b58

…adotnet#2661)

[api-docs] Update docfx config to support new proj (akkadotnet#2669)

fc2f009

This PR updates the docfx configuration file to support .netStandard project files.

Generata XML docs for nuget packages (akkadotnet#2650)

7bc4c63

Horusiath force-pushed the akka-io branch 2 times, most recently from dd2cc7c to 98337f5 Compare May 16, 2017 20:01

enable netfx perf tests

c63c85e

Horusiath force-pushed the akka-io branch from 98337f5 to 46dc134 Compare May 17, 2017 18:29

Marc Piechura and others added 5 commits May 18, 2017 06:48

Merge pull request akkadotnet#2680 from heynickc/netfx-perf-tests

4e4883f

Enable performance tests on Windows/.NET Framework

Update FsPickler nuget package to v3.2.0

3bbc0a5

[api-docs][misc]Various fixes (akkadotnet#2635)

581cc24

This PR fixes a number of spelling typos, a number of copyright headers, replaces various bits with <inheritdoc/>, and fills in more TBD placeholders.

rework of Akka.IO namespace

7dd882e

fixed post rebase issues

9ffd7ac

Horusiath force-pushed the akka-io branch from 46dc134 to 9ffd7ac Compare May 18, 2017 21:21

Horusiath closed this May 18, 2017

Horusiath mentioned this pull request May 23, 2017

Rework of Akka.IO (v1.3) #2683

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Akka.IO and Streams update #2405

[WIP] Akka.IO and Streams update #2405

Horusiath commented Dec 8, 2016 •

edited

Horusiath commented Jan 14, 2017

alexvaluyskiy commented Jan 14, 2017

Horusiath commented Jan 14, 2017

alexvaluyskiy commented Jan 15, 2017

Horusiath commented Jan 15, 2017

alexvaluyskiy commented Jan 16, 2017

Horusiath commented Jan 16, 2017 •

edited

Aaronontheweb commented Jan 17, 2017

Horusiath commented Feb 13, 2017

alexvaluyskiy commented Mar 2, 2017

Horusiath commented Mar 10, 2017

alexvaluyskiy commented Mar 10, 2017

alexvaluyskiy May 3, 2017

Horusiath commented May 3, 2017

Aaronontheweb commented May 9, 2017

alexvaluyskiy commented May 9, 2017

[WIP] Akka.IO and Streams update #2405

[WIP] Akka.IO and Streams update #2405

Conversation

Horusiath commented Dec 8, 2016 • edited

Horusiath commented Jan 14, 2017

alexvaluyskiy commented Jan 14, 2017

Horusiath commented Jan 14, 2017

alexvaluyskiy commented Jan 15, 2017

Horusiath commented Jan 15, 2017

alexvaluyskiy commented Jan 16, 2017

Horusiath commented Jan 16, 2017 • edited

Aaronontheweb commented Jan 17, 2017

Horusiath commented Feb 13, 2017

alexvaluyskiy commented Mar 2, 2017

Horusiath commented Mar 10, 2017

alexvaluyskiy commented Mar 10, 2017

alexvaluyskiy May 3, 2017

Choose a reason for hiding this comment

Horusiath commented May 3, 2017

Aaronontheweb commented May 9, 2017

alexvaluyskiy commented May 9, 2017

Horusiath commented Dec 8, 2016 •

edited

Horusiath commented Jan 16, 2017 •

edited