PostgreSQL persistence plugin for both event journal and snapshot store #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re. See issue #944 -Largely ported from Akka.Persistence.SqlServer plugin -Event journal and snapshot store specs passing -Added separate build task for PostgreSql tests -Added initial draft of readme and nuspec file
|
Great job! 😄 In my opinion, code looks good. As I understand, you've run the |
|
Yes, I ran the tests from Akka.Persistence.TestKit, and everything is passing. For what it's worth, I ran them a bunch of times without any issues. |
Horusiath
added a commit
that referenced
this pull request
May 13, 2015
PostgreSQL persistence plugin for both event journal and snapshot store
|
Wow, that was quick. Thank you very much. Now, onto the next issue! |
This was referenced Jun 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #944
-Largely ported from Akka.Persistence.SqlServer plugin
-Event journal and snapshot store specs passing
-Added separate build task for PostgreSql tests
-Added initial draft of readme and nuspec file
-There is still one potentially unresolved issue pertaining to passing in a connection string to the test runner inside build.fsx. Right now, I put the connection string (with credentials) in the app.config of the test project. There is currently no way to pass in a custom connection string or custom credentials using the test runner inside build.fsx. I was talking to @Aaronontheweb last week, and one of his suggestions was to create a "PersistenceTestRunner" that would modify the app.config before the tests are run. I wanted to double check before I wrote a test runner. Comments?