-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement HOCON reference config loading #48
Comments
The only problem I have with this strategy is that, depending on the platform and build, there is no guarantee where Akka.dll will be located during runtime. |
yeah, it's definitely going to need to be skunked out via lots of testing. |
What do you mean by "topologically sorted way"? |
Following in the order of its dependencies
I.e. Akka.Cluster --> Akka.remote --> Akka
…Sent from my iPhone
On Aug 11, 2019, at 9:55 AM, Gregorius Soedharmo ***@***.***> wrote:
What do you mean by "topologically sorted way"?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Won't that be a problem because each plug-in would have to know all of its dependency ahead of time? |
This should probably be an Akka.NET issue, actually. Have a better idea for how to do this with the built-in Akka.NET modules. |
Another example of where this would have been helpful: akkadotnet/akka.net#5383 |
Copy of issue akkadotnet/akka.net#3054
In order to better resolve issues like:
akkadotnet/akka.net#3031
akkadotnet/akka.net#3051
I propose that we do the following:
reference.conf
file per NuGet package and always stored in the same place.Akka.dll
and if they match a known assembly name / convention (i.e. core Akka.NET assemblies or Persistence plugins following theAkka.Persistence.*
convention), chain those configurations together in a topologically sorted way.This is how the JVM does it using the
reference.conf
files that ship as parts of the JAR files they deliver with each module, loaded via some of the tools in the stand-alone HOCON package:https://github.com/typesafehub/config/blob/master/config/src/main/java/com/typesafe/config/ConfigFactory.java
https://github.com/typesafehub/config/blob/master/config/src/main/java/com/typesafe/config/DefaultConfigLoadingStrategy.java#L25
This will avoid many of the issues we have with lots of plugins and forcing the end-user to have to manually include fallbacks for built-in libraries in their bootstrapping code.
The text was updated successfully, but these errors were encountered: