Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional http specific metrics #111

Closed
Tracked by #517
jfallows opened this issue Oct 7, 2022 · 0 comments · Fixed by #227
Closed
Tracked by #517

Support additional http specific metrics #111

jfallows opened this issue Oct 7, 2022 · 0 comments · Fixed by #227
Assignees
Labels
enhancement New feature or request

Comments

@jfallows
Copy link
Contributor

jfallows commented Oct 7, 2022

Note: requires design #109.

The following http metrics should be contributed to the Zilla engine's awareness of available metrics via the telemetry-http component, consistent with other pluggable aspects of the runtime.

  • http.duration: histogram
  • http.request_size: histogram
  • http.response_size: histogram
  • http.active_requests: updown

Note that the built-in counters for Zilla streams are all counters, so this will introduce new metrics types for updown and histogram.

The nature of the duration metric is also more stateful as there is a need to keep track of the request start timestamp and the later of the request and response end timestamps to capture the full duration of any request-response interaction.

Note: we need to validate that zilla metrics is reporting these new metrics types correctly as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants