Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Commit Pane is too eager #235

Closed
jsg2021 opened this issue Jul 17, 2015 · 8 comments
Closed

Commit Pane is too eager #235

jsg2021 opened this issue Jul 17, 2015 · 8 comments

Comments

@jsg2021
Copy link

jsg2021 commented Jul 17, 2015

I have auto-save turned on in atom, so when a pane blurs it saves. Git Plus's commit edit view closes and continues on save... this has bitten me several times.

Can we get an option to only continue the commit if-and-only-if:

  • I close the pane.
  • or I manually invoke the save key strokes
  • or use a new non-editor like git-control
  • or ignore auto-save for the commit editor
@radamant
Copy link

@jsg2021 I had this happen to me recently. I attempted to disable autosave in git commit buffers with the following:

"*[data-grammar~=\"git-commit\"]":
  autosave:
    enabled: false

but that seemed not to do the trick. Any ideas how to disable auto save when in a git-commit window?

@jsg2021
Copy link
Author

jsg2021 commented Jul 17, 2015

I don't know, that looks like something that should work. Will see what the atom team says. :)

@akonwi
Copy link
Owner

akonwi commented Aug 7, 2015

I've turned autosave on but I'm not having this problem. I'm changing tabs, toggling into the tree-view, and just about everything else while the commit message is open but it's still there until I save or close it.

@jsg2021
Copy link
Author

jsg2021 commented Aug 10, 2015

@akonwi do you have a message typed? if its the initial content, its okay.

@akonwi
Copy link
Owner

akonwi commented Aug 10, 2015

Ah I see. I'll try to make time and create a pull request to the autosave package to allow some configuration or a service for external packages to use. Hopefully the atom team beats me to it

@akonwi
Copy link
Owner

akonwi commented Dec 8, 2016

It doesn't seem like the autosave maintainers are going to accept my pull request or address the issue. I'm not sure what more to do and this is over a year old.

@akonwi akonwi closed this as completed in d8ac180 Dec 21, 2016
@akonwi
Copy link
Owner

akonwi commented Dec 21, 2016

My pull request to the autosave package has been merged and published. The changes to fix this issue will be in the next release

@jsg2021
Copy link
Author

jsg2021 commented Dec 21, 2016

:) 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants