This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
enable syntax highlighting in diffs #507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the tooltip this way allows it to comply with the current UI theme
|
I think this is great! I've pushed a change to your fork that hides the new highlighting behind the experimental toggle for now. The only request I have before merging this whether you can also implement this new highlighting for the word diff option that currently exists. |
|
It should work with or without Word Diff enabled. I had Word Diff on when I was developing and testing, and it worked for me. If you have a diff that gives error messages I'd like to use it to debug. |
|
Oh you're right. I didn't notice that only the changed words were underlined when the word diff option was on. Cool, I'll merge this into master and publish it tonight. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.