Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

[REQUEST] Support commit messages starting from issue hashtag (--cleanup=scissors) #654

Closed
schlomo opened this issue Apr 27, 2017 · 3 comments

Comments

@schlomo
Copy link

schlomo commented Apr 27, 2017

Our company requires git commit messages to start from an issue, e.g. #42. Because of this ATM I cannot use git-plus for commits :-(

My git config already has

[commit]
	cleanup = scissors

and running EDITOR="atom -w" git commit -v on the command line allows me to start the commit message with the hashtag.

When I use git-plus to commit then the commit message states that comments will be stripped showing me that the git config setting was not active.

Can you please add support for the scissors cleanup mode in git-plus?

I saw this mentioned in #90 and also tried changing the --cleanup option in lib/models/git-commit.coffee but it did not change anything.

@akonwi akonwi closed this as completed in 80b422b May 3, 2017
@schlomo
Copy link
Author

schlomo commented May 4, 2017

Cool - how can I test this?

@schlomo
Copy link
Author

schlomo commented May 4, 2017

Wow! I updated git+plus and now it "just" works - Thanks a lot for this quick fix!!

@akonwi
Copy link
Owner

akonwi commented May 4, 2017

No problem!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants