Permalink
Browse files

Try to make test :deferrables-unblocked-by-lock more robust

  - Use a join thread, not a kill thread, so that we do not kill the
    background thread while it is currently performing the actual
    test.

  - Give the thread more time to start up, to make it more likely
    that its GRAB-MUTEX call needs to wait -- otherwise deferrables would
    not be unblocked.
  • Loading branch information...
1 parent 991c149 commit ba534ac1b20426ce6ac673b993c427ea9180ac9c @lichtblau lichtblau committed Sep 30, 2012
Showing with 2 additions and 2 deletions.
  1. +2 −2 tests/threads.impure.lisp
@@ -86,7 +86,7 @@
(with-test (:name (:interrupt-thread :deferrables-unblocked-by-lock))
(let ((lock (sb-thread::make-mutex))
- (thread (make-kill-thread (lambda ()
+ (thread (make-join-thread (lambda ()
(loop (sleep 1))))))
(sb-thread::grab-mutex lock)
(sb-thread:interrupt-thread thread
@@ -95,7 +95,7 @@
(sb-thread::grab-mutex lock)
(check-deferrables-unblocked-or-lose 0)
(sb-thread:abort-thread)))
- (sleep 1)
+ (sleep 3)
(sb-thread::release-mutex lock)))
;;; compare-and-swap

0 comments on commit ba534ac

Please sign in to comment.