Skip to content

Commit

Permalink
1.0.18.17: Alter some STYLE-WARNING names introduced in 1.0.18.16.
Browse files Browse the repository at this point in the history
  • Loading branch information
Richard M Kreuter committed Jul 11, 2008
1 parent 5d04a95 commit ee8c58a
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 14 deletions.
8 changes: 4 additions & 4 deletions package-data-list.lisp-expr
Original file line number Diff line number Diff line change
Expand Up @@ -1725,10 +1725,10 @@ is a good idea, but see SB-SYS re. blurring of boundaries."
"UNINTERESTING-REDEFINITION"
"REDEFINITION-WITH-DEFTRANSFORM"

"IGNORING-ASTERISKS-IN-VARIABLE-NAME"
"IGNORING-ASTERISKS-IN-LEXICAL-VARIABLE-NAME"
"IGNORING-ASTERISKS-IN-CONSTANT-VARIABLE-NAME"
"UNDEFINED-ALIEN"
"DUBIOUS-ASTERISKS-AROUND-VARIABLE-NAME"
"ASTERISKS-AROUND-LEXICAL-VARIABLE-NAME"
"ASTERISKS-AROUND-CONSTANT-VARIABLE-NAME"
"UNDEFINED-ALIEN-STYLE-WARNING"
#!+sb-eval
"LEXICAL-ENVIRONMENT-TOO-COMPLEX"
"CHARACTER-DECODING-ERROR-IN-COMMENT"
Expand Down
14 changes: 8 additions & 6 deletions src/code/condition.lisp
Original file line number Diff line number Diff line change
Expand Up @@ -1468,7 +1468,7 @@ is signaled, if the warning if of this type, it will be muffled.")
(redefinition-with-deftransform-transform warning)))))

;;; Various other STYLE-WARNINGS
(define-condition ignoring-asterisks-in-variable-name
(define-condition dubious-asterisks-around-variable-name
(style-warning simple-condition)
()
(:report (lambda (warning stream)
Expand All @@ -1477,15 +1477,17 @@ the usual naming convention (names like *FOO*) for special variables"
(simple-condition-format-control warning)
(simple-condition-format-arguments warning)))))

(define-condition ignoring-asterisks-in-lexical-variable-name
(ignoring-asterisks-in-variable-name)
(define-condition asterisks-around-lexical-variable-name
(dubious-asterisks-around-variable-name)
())

(define-condition ignoring-asterisks-in-constant-variable-name
(ignoring-asterisks-in-variable-name)
(define-condition asterisks-around-constant-variable-name
(dubious-asterisks-around-variable-name)
())

(define-condition undefined-alien (style-warning)
;; We call this UNDEFINED-ALIEN-STYLE-WARNING because there are some
;; subclasses of ERROR above having to do with undefined aliens.
(define-condition undefined-alien-style-warning (style-warning)
((symbol :initarg :symbol :reader undefined-alien-symbol))
(:report (lambda (warning stream)
(format stream "Undefined alien: ~S"
Expand Down
3 changes: 2 additions & 1 deletion src/code/foreign-load.lisp
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,8 @@ is never in the linkage-table."
(error 'undefined-alien-error :name symbol))
#!+linkage-table
((not addr)
(style-warn 'sb!kernel:undefined-alien :symbol symbol)
(style-warn 'sb!kernel:undefined-alien-style-warning
:symbol symbol)
(setf (gethash symbol undefineds) t)
(remhash symbol symbols)
(if datap
Expand Down
2 changes: 1 addition & 1 deletion src/compiler/defconstant.lisp
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
(unless (symbolp name)
(error "The constant name is not a symbol: ~S" name))
(when (looks-like-name-of-special-var-p name)
(style-warn 'sb!kernel:ignoring-asterisks-in-constant-variable-name
(style-warn 'sb!kernel:asterisks-around-constant-variable-name
:format-control "defining ~S as a constant"
:format-arguments (list name)))
(sb!c:with-source-location (source-location)
Expand Down
2 changes: 1 addition & 1 deletion src/compiler/early-c.lisp
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@
;; and then we happen to compile bar.lisp before foo.lisp.
(when (looks-like-name-of-special-var-p symbol)
;; FIXME: should be COMPILER-STYLE-WARNING?
(style-warn 'sb!kernel:ignoring-asterisks-in-lexical-variable-name
(style-warn 'sb!kernel:asterisks-around-lexical-variable-name
:format-control
"using the lexical binding of the symbol ~S, not the~@
dynamic binding"
Expand Down
2 changes: 1 addition & 1 deletion version.lisp-expr
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@
;;; checkins which aren't released. (And occasionally for internal
;;; versions, especially for internal versions off the main CVS
;;; branch, it gets hairier, e.g. "0.pre7.14.flaky4.13".)
"1.0.18.16"
"1.0.18.17"

0 comments on commit ee8c58a

Please sign in to comment.