This repository has been archived by the owner on Oct 10, 2019. It is now read-only.
Set up cache for items in the search result #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RSS items from the search result are created with no reference to the cache instance. This causes missing of item read/unread status. The bug is easy to reproduce: * load a feed with some items * start a new search that finds one or several items * read any item from the search result * quit search * run the same search again Expected result: already read items should NOT be marked as "unread". In this commit we deliberately assign a reference to the cache instance for all RSS items found in the database, the same way it's done in the `cache::internalize_rssfeed` method. A new unit test provides steps to reproduce behavior described above, so we can be sure that the bug is really fixed.
|
The code looks perfectly fine to me. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original attempt to fix the bug with read/unread status (#137) was quite far from the good solution, so I've decided to rewrite it from scratch.
I'm looking forward for feedback, especially on the test. I had very little C++ practice during several past years so there might be stupid errors in the code.