Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMP: allow inheritance on tests #58

Open
wants to merge 2 commits into
base: 14.0
Choose a base branch
from

Conversation

damdam-s
Copy link

@damdam-s damdam-s commented Jun 5, 2023

No description provided.

@damdam-s
Copy link
Author

damdam-s commented Jun 5, 2023

@hparfr or @sebastienbeau can you approve the workflow here please?

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #58 (22e9e74) into 14.0 (b1bc0ef) will decrease coverage by 12.41%.
The diff coverage is 44.00%.

❗ Current head 22e9e74 differs from pull request most recent head c1bf465. Consider uploading reports for the commit c1bf465 to get more accurate results

@@             Coverage Diff             @@
##             14.0      #58       +/-   ##
===========================================
- Coverage   82.44%   70.03%   -12.41%     
===========================================
  Files          47       48        +1     
  Lines         826      831        +5     
  Branches      154      155        +1     
===========================================
- Hits          681      582       -99     
- Misses        127      226       +99     
- Partials       18       23        +5     
Impacted Files Coverage Δ
sale_configurator_option/tests/common.py 30.00% <30.00%> (ø)
sale_configurator_option/tests/__init__.py 100.00% <100.00%> (ø)
sale_configurator_option/tests/test_sale_order.py 20.00% <100.00%> (-80.00%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damdam-s damdam-s force-pushed the 14.0-ease-test-extensibility branch from 1a3e0a8 to 2037e6b Compare June 5, 2023 13:03
@damdam-s damdam-s force-pushed the 14.0-ease-test-extensibility branch from 2037e6b to 22e9e74 Compare June 5, 2023 15:46
@@ -1 +1,2 @@
from . import common
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this import is useless as you import it from the required python module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants