Feat integrate realsense #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlingkang
reviewed
Nov 15, 2018
Remove commented out section for unsubscribing from the depth topic
…om the parameters file
|
I have address the comments you guys had. Please take a look when you get the chance. I have removed the max_diff variable as it was too difficult to calculate the correct value. |
SomeshDaga
reviewed
Nov 21, 2018
There was a problem hiding this comment.
@ryan-konno
Excellent work! Seems like it would be useful to the general ROS community with the way the code has been structured. Just some minor comments on indentation and spacing.
fix indentation
fix spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed slopes from the laserscan.
Trello