Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toastr doesn't appear #1099

Closed
2 tasks done
do-yeon opened this issue Dec 20, 2018 · 8 comments
Closed
2 tasks done

Toastr doesn't appear #1099

do-yeon opened this issue Dec 20, 2018 · 8 comments

Comments

@do-yeon
Copy link

do-yeon commented Dec 20, 2018

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request

Issue description

Current behavior:

First, you go to the dashboard page that includes some codes to show toastr on AfterViewInit. It will show toastr.
And then you go to login page(because of logout),
when you try to open again the dashboard, it doesn't appear.
The global overlay wrapper that contains nb-toastr-container is not in the login page.
so, whenever you get the dashboard again(right after opening one of auth page) angular will re-render layouts and components you made but toastr seems still holding destroyed nb-toastr-container and it's not re-rendered.

Expected behavior:

Showing toastr

Steps to reproduce:

with ngx-admin

  1. add toastr call on dashboard.
  2. open dashboard.
  3. go to one of auth page.
  4. back to dashboard
  5. toastr doesn't appear

Other information:

npm, node, OS, Browser

node: v10.13.0
npm: v6.4.1
Tested OS: Mac Mojave, Windows 10
Tested Browser: Chrome/Safari/Edge

Angular, Nebular

it's the same as the files in ngx-admin

feature request
is there any way to place toast component manually?
if a page I made is not in layout(but it imports theme module like auth page), there is no way to use toastr.
sometimes we need full screen page with using toastr this way.

@developcodeza-matthew
Copy link

I've been struggling with this for the past couple weeks as well. Hoping someone has a solution.

@FilipK23
Copy link

I have the same problem. If I change module 2 times than toasts does not appear. I have my own modules client and admin and if I go from client to admin and back than any toast show. With login and logout it is the same.

@FilipK23
Copy link

Hello @nnixaa its not fixed.

Using 3.2.1 version (so latest release) and still not working.

@nnixaa
Copy link
Collaborator

nnixaa commented Feb 14, 2019

It is scheduled for 3.3.0, should be released relatively soon:
image

@yggg yggg modified the milestones: 3.4.0, 3.3.0 Feb 20, 2019
@Eve-Sama
Copy link
Contributor

I have the same problem.

@FilipK23
Copy link

I still have the same issue. When I navigate from auth module to main module toastr doesn't appear. (version 4.5.0)

@mirpuicor
Copy link

It is scheduled for 3.3.0, should be released relatively soon:
image

Same problem with v 5.0.0

@ganesh2ram
Copy link

Temporary Work around:
Go to node_modules/@nebular/theme/components/toastr/toastr.service.js
Go to line no:103
NbToastrContainerRegistry.prototype.get = function (position) {
var logicalPosition = this.positionHelper.toLogicalPosition(position);
// if (!this.overlays.has(logicalPosition)) {
this.instantiateContainer(logicalPosition);
// }
return this.overlays.get(logicalPosition);
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants