Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toastr): recreate container when it's not attached to dom #1224

Merged
merged 4 commits into from
Feb 11, 2019

Conversation

nnixaa
Copy link
Collaborator

@nnixaa nnixaa commented Feb 11, 2019

Closes #1099

@nnixaa nnixaa requested a review from Tibing February 11, 2019 13:15
@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #1224 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1224      +/-   ##
==========================================
+ Coverage   79.83%   79.85%   +0.02%     
==========================================
  Files         202      202              
  Lines        6223     6230       +7     
  Branches      492      492              
==========================================
+ Hits         4968     4975       +7     
  Misses       1141     1141              
  Partials      114      114
Impacted Files Coverage Δ
...ramework/theme/components/toastr/toastr.service.ts 72.44% <100%> (+2.11%) ⬆️

@nnixaa nnixaa merged commit 3343136 into master Feb 11, 2019
@nnixaa nnixaa deleted the feat/fix-toastr branch February 11, 2019 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant